Skip to content

Sync .github/skills directory with azure-sdk-tools for PR 16972 - #50417

Merged
Helen Gao (helen229) merged 2 commits into
mainfrom
sync-.github-skills-feature/16703-release-plan-schedule-warnings-16972
Sep 11, 2026
Merged

Helen Gao (helen229) merged 2 commits into
mainfrom
sync-.github-skills-feature/16703-release-plan-schedule-warnings-16972

Conversation

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

Sync .github/skills directory with azure-sdk-tools for PR Azure/azure-sdk-tools#16972 See eng/common workflow

Surface past-due and due-soon plans for the same TypeSpec project during get and create workflows, and align skill and mock coverage for spec-PR lookups.
Preserve fetch-stage cancellation, complete mock lookup coverage, retain requested spec PR URLs, and fix the plugin documentation link.
@azure-sdk-automation
azure-sdk-automation Bot requested review from Helen Gao (helen229) and a lite review from Copilot September 11, 2026 12:00
@azure-sdk-automation azure-sdk-automation Bot added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Sep 11, 2026
@azure-sdk-automation
azure-sdk-automation Bot requested a review from a team as a code owner September 11, 2026 12:00
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
36 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Operational documentation and evaluation coverage have unresolved gaps.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This pull request syncs the release-plan skill with updated Azure SDK tools and adds schedule-risk evaluation coverage.

Changes:

  • Consolidates release-plan lookup and target-month update guidance.
  • Adds past-due release-plan and schedule-risk instructions.
  • Adds schedule-risk evaluation scenarios.
File summaries
File Summary
.github/skills/azsdk-common-prepare-release-plan/SKILL.md Updates release-plan tooling and schedule-risk guidance; target-update usage needs operational documentation and an example.
.github/skills/azsdk-common-prepare-release-plan/evals/schedule-risk.eval.yaml Adds past-due scenarios; evaluations need explicit release-type input and stronger assertions for plan details and concrete risk output.
Review details

Suppressed comments (3)

.github/skills/azsdk-common-prepare-release-plan/evals/schedule-risk.eval.yaml:36

  • This grader does not verify the new requirement to show the actual Release Plan ID and dashboard link or to relay concrete warnings/next_steps; generic text containing these words would pass. Assert the mock response's plan identifier, dashboard URL (or a URL pattern), and at least one concrete schedule-risk value.
          pattern: "(?is)(?=.*past[- ]due)(?=.*(?:postpone|update).*(?:target|release month))(?=.*(?:abandon|close).*(?:reason|dashboard))"

.github/skills/azsdk-common-prepare-release-plan/evals/schedule-risk.eval.yaml:53

  • This grader does not verify the new requirement to show the actual Release Plan ID and dashboard link or to relay concrete warnings/next_steps; generic text containing these words would pass. Assert the mock response's plan identifier, dashboard URL (or a URL pattern), and at least one concrete schedule-risk value.
          pattern: "(?is)(?=.*past[- ]due)(?=.*(?:postpone|update).*(?:target|release month))(?=.*(?:abandon|close).*(?:reason|dashboard))"

.github/skills/azsdk-common-prepare-release-plan/evals/schedule-risk.eval.yaml:83

  • This grader does not verify the new requirement to show the actual Release Plan ID and dashboard link or to relay concrete warnings/next_steps; generic text containing these words would pass. Assert the mock response's plan identifier, dashboard URL (or a URL pattern), and at least one concrete schedule-risk value.
          pattern: "(?is)(?=.*past[- ]due)(?=.*(?:postpone|update).*(?:target|release month))(?=.*(?:abandon|close).*(?:reason|dashboard))"
  • Files reviewed: 2/2 changed files
  • Comments generated: 2
  • Review effort level: Lite

@helen229
Helen Gao (helen229) merged commit c46fd06 into main Sep 11, 2026
20 of 21 checks passed
@helen229
Helen Gao (helen229) deleted the sync-.github-skills-feature/16703-release-plan-schedule-warnings-16972 branch September 11, 2026 18:29
browndav-msft pushed a commit to browndav-msft/azure-sdk-for-java that referenced this pull request Oct 14, 2026
…e#50417)

* Warn about release plan schedule risks

Surface past-due and due-soon plans for the same TypeSpec project during get and create workflows, and align skill and mock coverage for spec-PR lookups.

* Address schedule risk review feedback

Preserve fetch-stage cancellation, complete mock lookup coverage, retain requested spec PR URLs, and fix the plugin documentation link.

---------

Co-authored-by: helen229 <gaoh@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants