Repository navigation
[Storage] STG105 Photon on by Default #50477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
browndav-msft
merged 24 commits into
Azure:feature/storage/stg105base
from
browndav-msft:stg105/photonOnByDefault
Oct 28, 2026
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
ef52222
change default serialization format to arrow
browndav-msft b38a3a2
consolidate setters for photon, photon on by default
browndav-msft c455b92
add ARROW enum check
browndav-msft f332e5c
change default tests to check for arrow and not xml
browndav-msft 1907177
rerecord failing tests so arrow returned and not xml in recordings
browndav-msft fdd1dbd
recorded more failing tests for arrow
browndav-msft 5efd0d4
change previous tests to check for xml explicitly, restore previous r…
browndav-msft f550396
restore recordings for failing tests, add xml explitly
browndav-msft ed6ed3e
spotless apply
browndav-msft 9ae3cfc
Exercise default Arrow listing in restored tests for live CI
browndav-msft 56b2c56
Revert "Exercise default Arrow listing in restored tests for live CI"
browndav-msft 220293f
Use new Arrow recordings for encryption-scope and version listings
browndav-msft a9b43a3
Restore missing File Share range-listing recordings
browndav-msft 25e4509
spotless apply
browndav-msft 90cbc86
push updated recordings for failing tests
browndav-msft 2f6d0ae
retain xml header request for single failing test, setAttributesTier
browndav-msft 6bd6933
change hard asserts for HOT to what was reqeusted
browndav-msft 5ee0d33
move tests from BlobContainerAsyncCLientTests to ContainerApiTests an…
browndav-msft d246328
add entry to changelog
browndav-msft b5c9161
Merge branch 'feature/storage/stg105base' of https://github.com/Azure…
ibrandes 9618583
Merge branch 'feature/storage/stg105base' of https://github.com/Azure…
ibrandes b8c48fa
file share test recordings
ibrandes 9b13efc
blob assets
ibrandes b8dd31b
updating recordings
ibrandes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
84 changes: 84 additions & 0 deletions
84
...age/azure-storage-blob/src/test/java/com/azure/storage/blob/BlobContainerClientTests.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
|
|
||
| package com.azure.storage.blob; | ||
|
|
||
| import com.azure.core.http.HttpHeaderName; | ||
| import com.azure.core.http.HttpPipeline; | ||
| import com.azure.core.http.HttpPipelineBuilder; | ||
| import com.azure.core.test.http.MockHttpResponse; | ||
| import com.azure.core.test.utils.MockTokenCredential; | ||
| import com.azure.storage.blob.models.BlobStorageException; | ||
| import com.azure.storage.blob.models.ListBlobsOptions; | ||
| import com.azure.storage.blob.models.StorageResponseSerializationFormat; | ||
| import com.azure.storage.common.implementation.Constants; | ||
| import org.junit.jupiter.api.BeforeEach; | ||
| import org.junit.jupiter.params.ParameterizedTest; | ||
| import org.junit.jupiter.params.provider.Arguments; | ||
| import org.junit.jupiter.params.provider.MethodSource; | ||
| import reactor.core.publisher.Mono; | ||
|
|
||
| import java.util.concurrent.atomic.AtomicReference; | ||
| import java.util.function.Supplier; | ||
| import java.util.stream.Stream; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
|
|
||
| public class BlobContainerClientTests { | ||
| private AtomicReference<String> acceptHeader; | ||
| private BlobContainerClient client; | ||
|
|
||
| @BeforeEach | ||
| public void setup() { | ||
| acceptHeader = new AtomicReference<>(); | ||
| HttpPipeline pipeline = new HttpPipelineBuilder().httpClient(request -> { | ||
| acceptHeader.set(request.getHeaders().getValue(HttpHeaderName.ACCEPT)); | ||
| // Fail after capturing the request so the test doesn't need a format-specific response body. | ||
| return Mono.just(new MockHttpResponse(request, 500)); | ||
| }).build(); | ||
| client = new BlobContainerClientBuilder().endpoint("https://account.blob.core.windows.net/container") | ||
| .credential(new MockTokenCredential()) | ||
| .pipeline(pipeline) | ||
| .buildClient(); | ||
| } | ||
|
|
||
| @ParameterizedTest | ||
| @MethodSource("serializationFormatSupplier") | ||
| public void listBlobsUsesResolvedSerializationFormat(ListBlobsOptions options, String expectedAcceptHeader) { | ||
| sendRequest(() -> client.listBlobs(options, null).iterableByPage(1).iterator().hasNext()); | ||
| assertEquals(expectedAcceptHeader, acceptHeader.get()); | ||
| } | ||
|
|
||
| @ParameterizedTest | ||
| @MethodSource("serializationFormatSupplier") | ||
| public void listBlobsByHierarchyUsesResolvedSerializationFormat(ListBlobsOptions options, | ||
| String expectedAcceptHeader) { | ||
| sendRequest(() -> client.listBlobsByHierarchy("/", options, null).iterableByPage(1).iterator().hasNext()); | ||
| assertEquals(expectedAcceptHeader, acceptHeader.get()); | ||
| } | ||
|
|
||
| private static void sendRequest(Supplier<?> request) { | ||
| try { | ||
| request.get(); | ||
| } catch (BlobStorageException exception) { | ||
| if (exception.getStatusCode() != 500) { | ||
| throw exception; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private static Stream<Arguments> serializationFormatSupplier() { | ||
| String arrowAcceptHeader | ||
| = Constants.ContentTypeConstants.APPLICATION_VND_APACHE_ARROW_STREAM + ",application/xml"; | ||
| return Stream.of(Arguments.of(null, arrowAcceptHeader), Arguments.of(new ListBlobsOptions(), arrowAcceptHeader), | ||
| Arguments.of( | ||
| new ListBlobsOptions().setStorageResponseSerializationFormat(StorageResponseSerializationFormat.AUTO), | ||
| arrowAcceptHeader), | ||
| Arguments.of( | ||
| new ListBlobsOptions().setStorageResponseSerializationFormat(StorageResponseSerializationFormat.ARROW), | ||
| arrowAcceptHeader), | ||
| Arguments.of( | ||
| new ListBlobsOptions().setStorageResponseSerializationFormat(StorageResponseSerializationFormat.XML), | ||
| "application/xml")); | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.