Repository navigation
[Search] Make event wrapper constructors package-private - #50834
Merged
Xiaofei Cao (XiaofeiCao) merged 5 commits intoOct 19, 2026
Merged
Xiaofei Cao (XiaofeiCao) merged 5 commits into
Xiaofei Cao (XiaofeiCao) merged 5 commits into
Conversation
Keep decoding in the converter and register typed package-private constructors from the base model. Generate the concrete base and SDK-only payload wrappers through Search customizations, and cover constructor visibility, payload identity, unknown events, malformed data, and cold initialization. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: aa365f59-c459-44fc-8076-1d59c78dc0b8
Delete the newly added model test file as requested without changing existing tests or production code. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: aa365f59-c459-44fc-8076-1d59c78dc0b8
Route the existing NoSuchElementException through ClientLogger to satisfy Checkstyle without changing iterator exhaustion semantics. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: aa365f59-c459-44fc-8076-1d59c78dc0b8
|
Azure Pipelines: 35 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: aa365f59-c459-44fc-8076-1d59c78dc0b8
Xiaofei Cao (XiaofeiCao)
marked this pull request as ready for review
October 16, 2026 05:59
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: aa365f59-c459-44fc-8076-1d59c78dc0b8
Xiaofei Cao (XiaofeiCao)
changed the title
efrainretana
approved these changes
Oct 16, 2026
github-project-automation
Bot
moved this from Untriaged
to In Progress
in Azure SDK for Search
Xiaofei Cao (XiaofeiCao)
merged commit Oct 19, 2026
7942892
into
Azure:search/2026-10-01-ga
2 checks passed
github-project-automation
Bot
moved this from In Progress
to Done
in Azure SDK for Search
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Targets #50648 (
search/2026-10-01-ga). No new specification changes; the existing TypeSpec pin is retained.Also fix the existing SSE iterator Checkstyle violation by routing its exhausted-iterator exception through
ClientLogger.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines
Validation on JDK 17 with
AZURE_TEST_MODE=PLAYBACK: passed (exit 0): 142 tests, 0 failures, 0 errors, 0 skipped. Package build, SpotBugs, and JavaDoc: passed. Checkstyle: passed, 0 violations.Existing baseline Revapi failures (GA API removals) remain outside this change. Full green CI is not claimed.