Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
ed5c42f
Increment package versions for durabletask auto-releases (#50892)
azure-sdk-automation[bot] Oct 21, 2026
e827d94
Configurations: 'specification/containerservice/resource-manager/Mic…
azure-sdk-automation[bot] Oct 21, 2026
806284f
Increment package versions for keyvault/azure-resourcemanager-keyvaul…
azure-sdk-automation[bot] Oct 21, 2026
c578d1a
fix(ai-agents): tolerate absent generated tool enum in customization …
weidongxu-microsoft Oct 21, 2026
cc81e63
Add official support and validation for Vert.x 5.1 and 5.2 (#50886)
alzimmermsft Oct 21, 2026
e321055
Fix Batch bulk task retry race (#50881)
vcolin7 Oct 21, 2026
70f4187
Configurations: 'specification/horizondb/resource-manager/Microsoft.…
azure-sdk-automation[bot] Oct 21, 2026
6009424
[healthdataaiservices] Bounded storage readiness retry in test-resour…
jovinson-ms Oct 21, 2026
608ac02
Sync eng/common directory with azure-sdk-tools for PR 17315 (#50900)
azure-sdk-automation[bot] Oct 21, 2026
34ae643
Sync .github/workflows directory with azure-sdk-tools for PR 17346 (#…
azure-sdk-automation[bot] Oct 21, 2026
b9f5979
Make timeout configuration handling consistent across HTTP stacks (#5…
alzimmermsft Oct 21, 2026
353db51
[AutoPR azure-resourcemanager-netapp]-generated-from-SDK Generation -…
azure-sdk-automation[bot] Oct 22, 2026
3e6d49f
Increment package versions for horizondb auto-releases (#50902)
azure-sdk-automation[bot] Oct 22, 2026
db177b1
Align Projects with beta Azure Core (#50913)
weidongxu-microsoft Oct 22, 2026
792dd61
[skip ci] [Automation] Generate SDK based on TypeSpec 0.48.3 (#50897)
azure-sdk-automation[bot] Oct 22, 2026
991aa83
[AutoPR azure-resourcemanager-recoveryservicesbackup]-generated-from-…
azure-sdk-automation[bot] Oct 22, 2026
e633d9b
Increment package versions for containerservice releases (#50915)
azure-sdk-automation[bot] Oct 22, 2026
c428662
Improve changelog reporting for class/interface transitions (#50914)
XiaofeiCao Oct 22, 2026
29fced1
Mark a few outputs as non-production (#50898)
alzimmermsft Oct 22, 2026
68a0107
Increment package versions for recoveryservicesbackup auto-releases (…
azure-sdk-automation[bot] Oct 22, 2026
e386e50
Configurations: 'specification/redhatopenshift/resource-manager/Micr…
azure-sdk-automation[bot] Oct 22, 2026
fd4a97e
[Storage] Fix storage service-version gates for all-version tests (#5…
browndav-msft Oct 22, 2026
85e9274
Merge branch 'main' into feature/storage/stg105base
browndav-msft Oct 22, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
68 changes: 34 additions & 34 deletions .github/workflows/event-processor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,30 +17,24 @@ on:
permissions: {}

jobs:
# This event requires the Azure CLI to get the LABEL_SERVICE_API_KEY from the vault.
# Because the azure/login step adds time costly pre/post Az CLI commands to any every job
# it's used in, split this into its own job so only the event that needs the Az CLI pays
# the cost.
# Only newly opened issues need Azure login and secrets from Key Vault.
event-handler-with-azure:
if: ${{ github.event_name == 'issues' && github.event.action == 'opened' }}
permissions:
issues: write
pull-requests: write
# For OIDC auth
id-token: write
contents: read
name: Handle ${{ github.event_name }} ${{ github.event.action }} event with azure login
runs-on: ubuntu-latest
steps:
- name: 'Az CLI login'
uses: azure/login@7ddb5af1ef8758cf1353cf3b42f940aee27ba21c # v3.0.2
if: ${{ github.event_name == 'issues' && github.event.action == 'opened' }}
with:
client-id: e4cb9fd5-0875-4ca1-bc43-56196f5dfb8f
tenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
allow-no-subscriptions: true

- name: 'Run Azure CLI commands'
if: ${{ github.event_name == 'issues' && github.event.action == 'opened' }}
run: |
LABEL_SERVICE_API_KEY=$(az keyvault secret show \
--vault-name issue-labeler \
Expand All @@ -60,10 +54,6 @@ jobs:
echo "::add-mask::$APP_CONFIG_ENDPOINT"
echo "APP_CONFIG_ENDPOINT=$APP_CONFIG_ENDPOINT" >> "$GITHUB_ENV"

# To run github-event-processor built from source, for testing purposes, uncomment everything
# in between the Start/End-Build From Source comments and comment everything in between the
# Start/End-Install comments
# Start-Install
- name: Install GitHub Event Processor
run: >
dotnet tool install
Expand All @@ -72,28 +62,6 @@ jobs:
--add-source https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-net/nuget/v3/index.json
--global
shell: bash
# End-Install

# Testing checkout of sources from the Azure/azure-sdk-tools repository
# The ref: is the SHA from the pull request in that repository or the
# refs/pull/<PRNumber>/merge for the latest on any given PR. If the repository
# is a fork eg. <User>/azure-sdk-tools then the repository down below will
# need to point to that fork
# Start-Build
# - name: Checkout tools repo for GitHub Event Processor sources
# uses: actions/checkout@v3
# with:
# repository: Azure/azure-sdk-tools
# path: azure-sdk-tools
# ref: <refs/pull/<PRNumber>/merge> or <sha>

# - name: Build and install GitHubEventProcessor from sources
# run: |
# dotnet pack
# dotnet tool install --global --prerelease --add-source ../../../artifacts/packages/Debug Azure.Sdk.Tools.GitHubEventProcessor
# shell: bash
# working-directory: azure-sdk-tools/tools/github-event-processor/Azure.Sdk.Tools.GitHubEventProcessor
# End-Build

- name: Process Action Event
run: |
Expand All @@ -112,3 +80,35 @@ jobs:
with:
name: event
path: ${{ github.event_path }}

event-handler:
if: ${{ !(github.event_name == 'issues' && github.event.action == 'opened') }}
permissions:
issues: write
# PR events can dismiss approvals after untrusted changes.
pull-requests: write
name: Handle ${{ github.event_name }} ${{ github.event.action }} event
runs-on: ubuntu-latest
steps:
- name: Install GitHub Event Processor
run: >
dotnet tool install
Azure.Sdk.Tools.GitHubEventProcessor
--version 1.0.0-dev.20260403.1
--add-source https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-net/nuget/v3/index.json
--global
shell: bash

- name: Process Action Event
run: |
github-event-processor ${{ github.event_name }} ${{ github.event_path }}
shell: bash
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Archive github event data
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
if: always()
with:
name: event
path: ${{ github.event_path }}
4 changes: 2 additions & 2 deletions common/perf-test-core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
<includes combine.children="append">
<!-- Special allowance for performance libraries as they aren't shipped. -->
<include>com.beust:jcommander:[1.82]</include> <!-- {x-include-update;com.beust:jcommander;external_dependency} -->
<include>io.vertx:vertx-codegen:[4.5.32]</include> <!-- {x-include-update;io.vertx:vertx-codegen;external_dependency} -->
<include>io.vertx:vertx-codegen:[4.5.35]</include> <!-- {x-include-update;io.vertx:vertx-codegen;external_dependency} -->
<include>io.projectreactor:reactor-core:[3.8.7]</include> <!-- {x-include-update;io.projectreactor:reactor-core;external_dependency} -->
</includes>
</bannedDependencies>
Expand Down Expand Up @@ -94,7 +94,7 @@
<dependency>
<groupId>io.vertx</groupId>
<artifactId>vertx-codegen</artifactId>
<version>4.5.32</version> <!-- {x-version-update;io.vertx:vertx-codegen;external_dependency} -->
<version>4.5.35</version> <!-- {x-version-update;io.vertx:vertx-codegen;external_dependency} -->
<scope>provided</scope>
</dependency>
<dependency>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,13 @@
import japicmp.model.AccessModifier;
import japicmp.model.JApiChangeStatus;
import japicmp.model.JApiClass;
import japicmp.model.JApiClassType;
import japicmp.model.JApiClassType.ClassType;
import japicmp.model.JApiConstructor;
import japicmp.model.JApiField;
import japicmp.model.JApiMethod;
import japicmp.model.StaticModifier;
import javassist.CtMethod;
import javassist.bytecode.AccessFlag;

import java.util.ArrayList;
Expand Down Expand Up @@ -125,6 +128,11 @@ private void calcChangeLogForClass() {
case NEW: newFeature.add(String.format("* `%s` was added", getJApiClass().getFullyQualifiedName())); break;
case REMOVED: breakingChange.setClassLevelChangeType(BreakingChange.Type.REMOVED); break;
default:
if (isClassTypeChange(ClassType.CLASS, ClassType.INTERFACE)) {
breakingChange.addClassTypeChange("a class", "an interface");
} else if (isClassTypeChange(ClassType.INTERFACE, ClassType.CLASS)) {
breakingChange.addClassTypeChange("an interface", "a class");
}
boolean checkReturnType = !ClassName.name(getJApiClass()).equals("Definition");
allMethods.getConstructors().forEach(constructor -> this.calcChangelogForConstructor(constructor));
allMethods.getMethods().forEach(method -> this.calcChangelogForMethod(method, checkReturnType));
Expand All @@ -150,6 +158,9 @@ private void calcChangelogForMethod(JApiMethod method, boolean checkReturnType)
breakingChange.addMethodLevelChange(String.format("`%s` was removed", MethodName.name(method.getOldMethod().get())));
break;
case MODIFIED:
if (isRedundantAbstractnessChange(method)) {
break;
}
if (!checkReturnType){
if (!method.getOldMethod().get().getLongName().equals(method.getNewMethod().get().getLongName())) {
breakingChange.addMethodLevelChange(String.format("`%s` -> `%s`", MethodName.name(method.getOldMethod().get()), MethodName.name(method.getNewMethod().get())));
Expand All @@ -161,6 +172,29 @@ private void calcChangelogForMethod(JApiMethod method, boolean checkReturnType)
}
}

private boolean isClassTypeChange(ClassType oldType, ClassType newType) {
JApiClassType classType = getJApiClass().getClassType();
return classType.getOldTypeOptional().isPresent() && classType.getNewTypeOptional().isPresent()
&& classType.getOldTypeOptional().get() == oldType && classType.getNewTypeOptional().get() == newType;
}

private boolean isRedundantAbstractnessChange(JApiMethod method) {
boolean toInterface = isClassTypeChange(ClassType.CLASS, ClassType.INTERFACE);
if ((!toInterface && !isClassTypeChange(ClassType.INTERFACE, ClassType.CLASS))
|| !method.getjApiClass().getFullyQualifiedName().equals(getJApiClass().getFullyQualifiedName())) {
return false;
}
CtMethod oldMethod = method.getOldMethod().get();
CtMethod newMethod = method.getNewMethod().get();
return oldMethod.getSignature().equals(newMethod.getSignature())
&& Objects.equals(oldMethod.getGenericSignature(), newMethod.getGenericSignature())
&& (oldMethod.getModifiers() ^ newMethod.getModifiers()) == AccessFlag.ABSTRACT
&& ((newMethod.getModifiers() & AccessFlag.ABSTRACT) != 0) == toInterface
&& method.getAnnotations().stream().allMatch(annotation -> annotation.getChangeStatus() == JApiChangeStatus.UNCHANGED)
&& method.getExceptions().stream().allMatch(exception -> exception.getChangeStatus() == JApiChangeStatus.UNCHANGED)
&& method.getAttributes().stream().allMatch(attribute -> attribute.getChangeStatus() == JApiChangeStatus.UNCHANGED);
}

private void calcChangelogForConstructor(JApiConstructor constructor) {
switch (constructor.getChangeStatus()) {
case NEW:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ public class BreakingChange {

private final String className;
private Type type;
private final Set<String> classTypeChanges = new LinkedHashSet<>();
private final Set<String> methodChanges = new LinkedHashSet<>();
private final Set<String> fieldChanges = new LinkedHashSet<>();
private final Set<String> stageChanges = new LinkedHashSet<>();
Expand All @@ -39,6 +40,11 @@ public void addMethodLevelChange(String content) {
methodChanges.add(content);
}

public void addClassTypeChange(String oldType, String newType) {
setClassLevelChangeType(Type.MODIFIED);
classTypeChanges.add(String.format("%s to %s", oldType, newType));
}

public void addFieldLevelChange(String content) {
setClassLevelChangeType(Type.MODIFIED);
fieldChanges.add(content);
Expand All @@ -56,7 +62,10 @@ public String getForChangelog() {
StringBuilder builder = new StringBuilder();
builder.append(String.format("#### `%s` was %s\n\n", className, type.getDisplayName()));
int count = 0;
List<String> innerChanges = Stream.concat(Stream.concat(stageChanges.stream(), fieldChanges.stream()), methodChanges.stream()).collect(Collectors.toList());
List<String> innerChanges = Stream.of(classTypeChanges.stream().map(change -> String.format("Changed from %s.", change)),
stageChanges.stream(), fieldChanges.stream(), methodChanges.stream())
.flatMap(changes -> changes)
.collect(Collectors.toList());
for (String methodChange : innerChanges) {
builder
.append("* ")
Expand All @@ -73,16 +82,15 @@ public String getForChangelog() {
public Collection<String> getItems() {
if (type == Type.NOT_CHANGED) {
return Collections.emptyList();
} else if (methodChanges.isEmpty() && fieldChanges.isEmpty() && stageChanges.isEmpty()) {
} else if (classTypeChanges.isEmpty() && methodChanges.isEmpty() && fieldChanges.isEmpty() && stageChanges.isEmpty()) {
return Collections.singleton(String.format("Class `%s` was %s.", className, type.getDisplayName()));
} else {
return Stream.concat(
Stream.concat(
stageChanges.stream().map(stageChange -> String.format("%s in class `%s`.", stageChange, className)),
fieldChanges.stream().map(fieldChange -> String.format("Field %s in class `%s`.", fieldChange, className))
),
return Stream.of(
classTypeChanges.stream().map(change -> String.format("Type `%s` changed from %s.", className, change)),
stageChanges.stream().map(stageChange -> String.format("%s in class `%s`.", stageChange, className)),
fieldChanges.stream().map(fieldChange -> String.format("Field %s in class `%s`.", fieldChange, className)),
methodChanges.stream().map(methodChange -> String.format("Method %s in class `%s`.", methodChange, className))
).collect(Collectors.toList());
).flatMap(changes -> changes).collect(Collectors.toList());
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,27 @@ public void testBreakingChange() {
Assertions.assertEquals("Field `SWAGGER_LINK_JSON` was removed in class `MyClass`.", it.next());
}

@Test
public void testClassTypeChangeDetails() {
BreakingChange breakingChange = BreakingChange.onJavaClass("MyClass");
breakingChange.addClassTypeChange("a class", "an interface");
breakingChange.addClassTypeChange("a class", "an interface");
breakingChange.addMethodLevelChange("`sku()` was removed");
breakingChange.addFieldLevelChange("`VALUE` was removed");
breakingChange.addStageLevelChange("Required stage 3 was removed");

Assertions.assertEquals("#### `MyClass` was modified\n\n"
+ "* Changed from a class to an interface.\n"
+ "* Required stage 3 was removed\n"
+ "* `VALUE` was removed\n"
+ "* `sku()` was removed\n\n", breakingChange.getForChangelog());
Assertions.assertEquals(java.util.Arrays.asList(
"Type `MyClass` changed from a class to an interface.",
"Required stage 3 was removed in class `MyClass`.",
"Field `VALUE` was removed in class `MyClass`.",
"Method `sku()` was removed in class `MyClass`."), breakingChange.getItems());
}

@Test
public void testCompareJars() {
URL oldJar = BreakingChangeTests.class.getResource("/old.jar");
Expand Down
Loading
Loading