Skip to content

Update CI to report build failure as warning #50997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Weidong Xu (weidongxu-microsoft) merged 1 commit into from
Oct 28, 2026
Merged

Update CI to report build failure as warning #50997

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions eng/automation/generate_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,21 +34,22 @@ def sdk_automation_typespec_project(tsp_project: str, config: dict) -> dict:
)
clean_sdk_folder_succeeded = False

succeeded, require_sdk_integration, sdk_folder, service, module = generate_typespec_project(
generate_succeeded, require_sdk_integration, sdk_folder, service, module = generate_typespec_project(
tsp_project, sdk_root, spec_root, head_sha, repo_url
)

if not succeeded and fallback_generate_from_clean_folder_enabled:
if not generate_succeeded and fallback_generate_from_clean_folder_enabled:
# error in emitter
# fallback to generate from a clean folder
clean_sdk_folder_succeeded = clean_sdk_folder(sdk_root, sdk_folder)
if clean_sdk_folder_succeeded:
# re-generate
succeeded, require_sdk_integration, sdk_folder, service, module = generate_typespec_project(
generate_succeeded, require_sdk_integration, sdk_folder, service, module = generate_typespec_project(
tsp_project, sdk_root, spec_root, head_sha, repo_url, disable_customization=True
)

if succeeded:
compile_succeeded = False
if generate_succeeded:
stable_version, current_version = set_or_default_version(sdk_root, GROUP_ID, module)
if require_sdk_integration:
update_service_files_for_new_lib(sdk_root, service, GROUP_ID, module)
Expand All @@ -57,8 +58,8 @@ def sdk_automation_typespec_project(tsp_project: str, config: dict) -> dict:
current_version = DEFAULT_VERSION

# compile
succeeded = compile_package(sdk_root, GROUP_ID, module)
if succeeded:
compile_succeeded = compile_package(sdk_root, GROUP_ID, module)
if compile_succeeded:
breaking, changelog, breaking_change_items = compare_with_maven_package(
sdk_root,
GROUP_ID,
Expand All @@ -73,7 +74,7 @@ def sdk_automation_typespec_project(tsp_project: str, config: dict) -> dict:
clean_sdk_folder_succeeded = clean_sdk_folder(sdk_root, sdk_folder)
if clean_sdk_folder_succeeded:
# re-generate
succeeded, require_sdk_integration, sdk_folder, service, module = generate_typespec_project(
generate_succeeded, require_sdk_integration, sdk_folder, service, module = generate_typespec_project(
tsp_project, sdk_root, spec_root, head_sha, repo_url, disable_customization=True
)
stable_version, _ = set_or_default_version(sdk_root, GROUP_ID, module)
Expand All @@ -82,8 +83,8 @@ def sdk_automation_typespec_project(tsp_project: str, config: dict) -> dict:
update_service_files_for_new_lib(sdk_root, service, GROUP_ID, module)
update_root_pom(sdk_root, service)
# compile
succeeded = compile_package(sdk_root, GROUP_ID, module)
if succeeded:
compile_succeeded = compile_package(sdk_root, GROUP_ID, module)
if compile_succeeded:
breaking, changelog, breaking_change_items = compare_with_maven_package(
sdk_root,
GROUP_ID,
Expand All @@ -97,7 +98,9 @@ def sdk_automation_typespec_project(tsp_project: str, config: dict) -> dict:
if sdk_folder and module and service:
artifacts = ["{0}/pom.xml".format(sdk_folder)]
artifacts += [jar for jar in glob.glob("{0}/target/*.jar".format(sdk_folder))]
result = "succeeded" if succeeded else "failed"
result = "succeeded" if compile_succeeded else "failed"
if generate_succeeded and not compile_succeeded and fallback_generate_from_clean_folder_enabled:
result = "warning"

return {
"packageName": module,
Expand All @@ -110,7 +113,7 @@ def sdk_automation_typespec_project(tsp_project: str, config: dict) -> dict:
],
"typespecProject": [tsp_project],
"packageFolder": sdk_folder,
"artifacts": artifacts if succeeded else [],
"artifacts": artifacts if compile_succeeded else [],
"apiViewArtifact": next(iter(glob.glob("{0}/target/*-sources.jar".format(sdk_folder))), None),
"language": "Java",
"result": result,
Expand Down
Loading