[EngSys] Fix shared Vitest dependency resolution - #39845
Open
Jeremy Meng (jeremymeng) wants to merge 2 commits into
Open
[EngSys] Fix shared Vitest dependency resolution#39845Jeremy Meng (jeremymeng) wants to merge 2 commits into
Jeremy Meng (jeremymeng) wants to merge 2 commits into
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). 9 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started reviewing on behalf of
Jeremy Meng (jeremymeng)
September 2, 2026 21:35
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The reviewed change resolves dependency imports with no unresolved issues.
Warning
- Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.
Pull request overview
Declares shared Vitest dependencies at the workspace root for strict pnpm resolution.
Changes:
- Adds catalog-managed
vitestand@types/nodedevelopment dependencies.
File summaries
| File | Description |
|---|---|
package.json |
Declares dependencies required by the shared Vitest configuration. |
Review details
Files excluded by content exclusion policy (1)
- pnpm-lock.yaml
- Files reviewed: 1/2 changed files
- Comments generated: 0
- Review effort level: Balanced
Copilot started reviewing on behalf of
Jeremy Meng (jeremymeng)
September 3, 2026 00:36
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The reviewed change resolves dependency ownership with no unresolved issues.
Warning
- Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.
Review details
Files excluded by content exclusion policy (1)
- pnpm-lock.yaml
- Files reviewed: 1/2 changed files
- Comments generated: 0 new
- Review effort level: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot agent
(on behalf of Jeremy Meng (@jeremymeng)): Fix shared Vitest configuration imports under pnpm's strict dependency resolution.
Packages impacted by this PR
All packages that consume the repository's shared Vitest configuration. The change is owned by the root
@azure/monorepoworkspace package.Issues associated with this PR
N/A
Describe the problem that is addressed by this PR
The root
vitest.shared.config.tsimportsvitest/configandvitest/node, but the root package did not declare Vitest. When a leaf SDK package loaded this shared configuration, the config bundler could not resolve those imports from the root and emittedUNRESOLVED_IMPORTwarnings even though tests passed.This PR declares Vitest at the root and also declares the existing
@types/nodecatalog dependency so pnpm reuses the repository's Node 22 Vite peer variant instead of creating a Node 25 variant.What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
The alternatives were to duplicate or redirect Vitest imports in each leaf package, or change config loading to tolerate unresolved imports. Declaring the dependencies where the shared configuration lives preserves strict resolution and fixes all consumers without per-package changes.
Are there test cases added in this PR? (If not, why?)
No new test case is needed because this is a dependency-resolution correction. The original
@azure/storage-queuecommand was run and completed with 21 passing tests without eitherUNRESOLVED_IMPORTwarning:npm run test:node -- -- .\test\queueclient.spec.tsProvide a list of related PRs (if any)
N/A
Command used to generate this PR:**(Applicable only to SDK release request PRs)
N/A
Checklists