Sync eng/common directory with azure-sdk-tools for PR 16685 - #10222
Open
azure-sdk-automation[bot] wants to merge 2 commits into
Open
Sync eng/common directory with azure-sdk-tools for PR 16685#10222azure-sdk-automation[bot] wants to merge 2 commits into
azure-sdk-automation[bot] wants to merge 2 commits into
Conversation
Bump @microsoft/vally-cli to 0.12.0 in eng/skill-eval and eng/common/scripts/eval and regenerate lockfiles. Add npm 11.11.1 install steps to the skill-eval workflow and the shared eval-shard pipeline template to satisfy the new npm floor.
Bump compatibility to @microsoft/vally-cli 0.12.0 in the eval-authoring skills and document the new 0.12 requirements: npm 11.11.1 / Node 22 prereqs, mandatory eval-spec schema lint, named-environment validation, type-based scoring with weights summing to 1.0, enforced step durations, and runtime executor verification. Correct the tool-calls ordering field from 'ordered' to 'sequence'.
azure-sdk-automation
Bot
added
EngSys
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.
Updates the Vally eval tooling to use a newer @microsoft/vally-cli and standardizes CI/local environments by pinning newer Node/npm requirements.
Changes:
- Bump
@microsoft/vally-clifrom0.7.0to0.12.0. - Add npm engine requirement and update Node engine floor in the eval package.
- Pin npm
11.11.1in CI and document the lockfile refresh workflow.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| eng/common/scripts/eval/package.json | Updates engine requirements and bumps @microsoft/vally-cli. |
| eng/common/scripts/eval/README.md | Documents the new npm pin and lockfile refresh commands. |
| eng/common/pipelines/templates/jobs/eval-shard.yml | Pins npm version in the eval shard CI job before npm ci. |
Files not reviewed (1)
- eng/common/scripts/eval/package-lock.json: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Helen Gao (helen229)
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#16685 See eng/common workflow