Sync eng/common directory with azure-sdk-tools for PR 16858 - #10258
Merged
Travis Prescott (tjprescott) merged 1 commit intoAug 31, 2026
Merged
Conversation
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Hardens API Review Hub pipeline templates by passing parameters through environment variables instead of interpolating them into scripts.
Changes:
- Safely passes paths, refs, and metadata into PowerShell and Bash.
- Uses
Join-Pathfor state-directory construction.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
eng/common/pipelines/templates/steps/create-apireview-hub-artifacts-base.yml |
Secures artifact preparation, checkout, and metadata steps. |
eng/common/pipelines/templates/jobs/apireview-hub-job-base.yml |
Secures repository clone parameter handling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Travis Prescott (tjprescott)
approved these changes
Aug 31, 2026
Travis Prescott (tjprescott)
deleted the
sync-eng-common-arh/baseTemplateFix-16858
branch
August 31, 2026 20:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#16858 See eng/common workflow