Skip to content

Sync eng/common directory with azure-sdk-tools for PR 16858 - #10258

Merged
Travis Prescott (tjprescott) merged 1 commit into
mainfrom
sync-eng-common-arh/baseTemplateFix-16858
Aug 31, 2026
Merged

Sync eng/common directory with azure-sdk-tools for PR 16858#10258
Travis Prescott (tjprescott) merged 1 commit into
mainfrom
sync-eng-common-arh/baseTemplateFix-16858

Conversation

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#16858 See eng/common workflow

Copilot AI balanced review requested due to automatic review settings August 31, 2026 20:14
@azure-sdk-automation
azure-sdk-automation Bot requested a review from a team as a code owner August 31, 2026 20:14
@azure-sdk-automation azure-sdk-automation Bot added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Aug 31, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
1 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Hardens API Review Hub pipeline templates by passing parameters through environment variables instead of interpolating them into scripts.

Changes:

  • Safely passes paths, refs, and metadata into PowerShell and Bash.
  • Uses Join-Path for state-directory construction.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
eng/common/pipelines/templates/steps/create-apireview-hub-artifacts-base.yml Secures artifact preparation, checkout, and metadata steps.
eng/common/pipelines/templates/jobs/apireview-hub-job-base.yml Secures repository clone parameter handling.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@tjprescott
Travis Prescott (tjprescott) merged commit c033a5e into main Aug 31, 2026
9 of 10 checks passed
@tjprescott
Travis Prescott (tjprescott) deleted the sync-eng-common-arh/baseTemplateFix-16858 branch August 31, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants