Sync eng/common directory with azure-sdk-tools for PR 16968 - #10272
Merged
Conversation
Invoke-Cspell.ps1 works fine when piping a list of file names to it from within PowerShell, but not another shell like bash. This is the fix.
azure-sdk-automation
Bot
added
EngSys
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused change correctly supports both Bash and PowerShell pipeline input.
Pull request overview
Updates the shared cspell wrapper to accept file lists from standard input across PowerShell and external shells.
Changes:
- Defaults
FileListto PowerShell’s$inputstream. - Documents cross-shell stdin behavior.
File summaries
| File | Description |
|---|---|
eng/common/spelling/Invoke-Cspell.ps1 |
Enables stdin file lists from shells such as Bash. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Heath Stewart (heaths)
approved these changes
Sep 9, 2026
Mike Harder (mikeharder)
deleted the
sync-eng-common-fix-cspell-16968
branch
September 9, 2026 20:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#16968 See eng/common workflow