Core: Add framework-neutral model client adapters - #524
Draft
Minseok Song (skytin1004) wants to merge 1 commit into
Draft
Core: Add framework-neutral model client adapters#524Minseok Song (skytin1004) wants to merge 1 commit into
Minseok Song (skytin1004) wants to merge 1 commit into
Conversation
Collaborator
Author
|
CI status note: Python 3.11-3.14, the Python 3.14 requirements check, CodeQL, and documentation build all pass. The Co-op review check reports 110 structure errors because the two changed documentation files (AGENTS.md and docs/configuration.md) do not have corresponding files in each of the 55 translation directories. This is documentation-translation coverage, not a model-client test or runtime failure; I am leaving the PR in Draft while that repository-wide documentation policy is considered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Introduce a framework-neutral model client boundary so Co-op Translator can evaluate Microsoft Agent Framework without exposing framework-specific types throughout the translation pipeline. Semantic Kernel remains the default backend.
Description
TranslationModelClientandModelResponseas the minimal internal completion contract.CO_OP_TRANSLATOR_MODEL_CLIENT=agent-framework; invalid values fail clearly.Related Issue
N/A
Does this introduce a breaking change?
Will this change require users to update commands, configuration, environment variables, generated translation output, or public Python/MCP APIs?
If you're not sure, test the affected CLI, API, documentation, or GitHub Actions workflow before marking this as "No."
Type of change
Checklist
Before submitting your pull request, please confirm the following:
Additional context
Validation completed:
pip checkpassphi4-mini:3.8bmodel did not preserve Co-op Translator's chunk envelope during a full Markdown translation, so Ollama model quality/compatibility is not claimed by this PRThis PR intentionally retains Semantic Kernel and keeps it as the default. It establishes the comparison boundary; it does not yet remove Semantic Kernel or promise production support for every Agent Framework provider.