Repository navigation
Conversation
FileExtension.contains() compared entry.suffix against the enum's lowercase values case-sensitively, so files with uppercase extensions (e.g. iPhone's default IMG_1234.MOV) were silently skipped, making the extractor report an empty input directory even when a valid video was present. Closes BKDDFS#199 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FileExtension.contains()comparedentry.suffixagainst the enum's lowercase extension values case-sensitively, so files with uppercase extensions (e.g. iPhone's defaultIMG_1234.MOV) were silently skipped by_list_input_directory_files, surfacing as a confusingEmptyInputDirectoryErroreven though a valid video was present in the input directory.Closes #199
Test plan
IMG_xxxx.MOV) ininput_directory, ranbest_frames_extractorviadocker-compose up+POST /v2/extractors/best_frames_extractor— failed withEmptyInputDirectoryErrorbefore the fix.frames_extracted_prefix as expected.