Repository navigation
Improve shader debugging workflow - #385
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Improves shader debugging by capturing shader data, exposing source links and diagnostics, and adding parser-backed GLSL formatting.
Changes:
- Capture shader/program status, sources, and diagnostic logs.
- Enhance the source editor with formatting, annotations, and preserved drafts.
- Add shader-debugging samples and automated coverage.
Reviewed changes
Copilot reviewed 29 out of 39 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
test/unit/embeddedFrontend/shaderDiagnostics.test.ts |
Tests diagnostic parsing. |
test/unit/backend/commands/shaderCommands.test.ts |
Tests shader command capture. |
test/integration/visual/source-code.spec.ts |
Tests editor workflows. |
test/integration/fixtures/test-scene.html |
Supports shader rebuilding. |
test/e2e/shaderDebugSample.spec.ts |
Tests debugging scenarios. |
src/shared/capture/programCapture.ts |
Extends shader capture data. |
src/shared/capture/commandCapture.ts |
Adds command shader/program captures. |
src/embeddedFrontend/styles/resultView.scss |
Styles diagnostic notices. |
src/embeddedFrontend/react/shared/types.ts |
Adds editor and render types. |
src/embeddedFrontend/react/shared/shaderFormatter.ts |
Formats GLSL. |
src/embeddedFrontend/react/shared/shaderDiagnostics.ts |
Parses compiler logs. |
src/embeddedFrontend/react/ResultView/SourceCode/SourceCode.tsx |
Enhances shader editor behavior. |
src/embeddedFrontend/react/ResultView/ResultViewRoot.tsx |
Connects source-opening handlers. |
src/embeddedFrontend/react/ResultView/ReactResultView.ts |
Opens captured shaders. |
src/embeddedFrontend/react/ResultView/jsonTreeBuilder.ts |
Builds shader detail entries. |
src/embeddedFrontend/react/ResultView/JSON/JSONShaderSourceItem.tsx |
Renders source links. |
src/embeddedFrontend/react/ResultView/JSON/JSONRenderTree.tsx |
Supports shader nodes. |
src/embeddedFrontend/react/ResultView/CommandList/CommandListItem.tsx |
Adds command source links. |
src/backend/utils/readProgramHelper.ts |
Captures logs and statuses. |
src/backend/spies/commandSpy.ts |
Registers shader commands. |
src/backend/commands/shaderSource.ts |
Captures compact source commands. |
src/backend/commands/linkProgram.ts |
Captures link results. |
src/backend/commands/getShaderInfoLog.ts |
Summarizes compiler logs. |
src/backend/commands/compileShader.ts |
Captures compilation results. |
src/backend/commands/baseShaderCommand.ts |
Shares shader capture logic. |
sample/js/shaderDebug.js |
Adds debugging sample scenarios. |
package.json |
Adds GLSL formatter dependencies. |
package-lock.json |
Locks formatter dependencies. |
documentation/changeLogs.md |
Documents the feature. |
dist/spector.d.ts |
Updates public declarations. |
.github/workflows/githubActions.yml |
Moves CI to Node 22. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
npm run buildnpm run test:unit -- --runInBandSample
Run
npm start, then open:http://localhost:1337/sample/index.html?sample=shaderDebugCloses #283