Add Chinese Num To Word - #37
Open
HCO168 wants to merge 7 commits into
Open
Conversation
|
Heyo. it might be needed to submit a commit where you remove the |
Laifsyn
reviewed
Nov 24, 2025
| .iter() | ||
| .find(|v| ["〇", "circle", "Circle", "yuan"].contains(&v.as_str())) | ||
| .is_some(); | ||
| let prefer_yishi = preferences |
There was a problem hiding this comment.
yuan might overlap or conflict a possible preference of 块 (kuai) and 元 (yuan) since in Guangdong 块 could be used in colloquial context[1].
Granted, all this is written chinese, so it's up for debate whether you want to write a number in their colloquial representation)
Author
There was a problem hiding this comment.
Sure, I will make those changes.
|
Somethings to consider:
IDEs LSPs like VSCode's rust-analyzer usually makes point 2 and 3 easier to solve. |
Author
|
The problems are fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.