Add Kobo Nia N306 support - #45
Conversation
|
Hi @DrWhax thanks for contributing this! We do not own this device so it helps if you can attach a video/gif of the Nia running Cobalt while I review and send comments. Once the reviews are taken care of would be happy to merge it for the Nia audience. Thanks again for your help. Here are examples of how other contributors have done so in their PRs #43 (comment) #26 (comment) |
|
In the meantime, the automated code review agent gave this feedback -
|
|
Video of Cobalt working: https://jurrevanbergen.nl/kobo.mp4 I'll look at the agent comments! |
|
My Kobo Nia is: |
|
OK, I've worked on some of the suggestions by your agent. |
|
Thanks for this! The last commit in the PR might have over deleted docs. It removed the pending DEVICES.md matrix row and the paragraph disclosing that the identity gate does not exclude the untested BD71828 hardware revision. We have recently merged another PR, can you please rebase to resolve conflicts. The Nia profile must be re-expressed in the new derived-geometry/ PanelPose structure, and the wait bypass integrated with refresh_timed. We can merge after that. Thanks again for all your help. |
I ported it to my Kobo Nia and I tested it on the device itself. It works well!
Let me know if any changes would need to be made.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.