Skip to content

Commit ca0bd6b

Browse files
committed
Align Safari extension signing settings
1 parent d06a55b commit ca0bd6b

3 files changed

Lines changed: 27 additions & 3 deletions

File tree

safari-app/Pluck/Pluck.xcodeproj/project.pbxproj

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@
222222
};
223223
};
224224
};
225-
buildConfigurationList = 3FE01093300443A2003A8AAE /* Build configuration list for PBXProject "Pluck Pins" */;
225+
buildConfigurationList = 3FE01093300443A2003A8AAE /* Build configuration list for PBXProject "Pluck" */;
226226
developmentRegion = en;
227227
hasScannedForEncodings = 0;
228228
knownRegions = (
@@ -442,8 +442,10 @@
442442
3FE010BE300443A3003A8AAE /* Debug */ = {
443443
isa = XCBuildConfiguration;
444444
buildSettings = {
445+
"CODE_SIGN_IDENTITY[sdk=macosx*]" = "Apple Development";
445446
CODE_SIGN_STYLE = Automatic;
446447
CURRENT_PROJECT_VERSION = 1;
448+
DEVELOPMENT_TEAM = 69NPZWZB47;
447449
ENABLE_APP_SANDBOX = YES;
448450
ENABLE_HARDENED_RUNTIME = YES;
449451
ENABLE_USER_SELECTED_FILES = readonly;
@@ -476,8 +478,10 @@
476478
3FE010BF300443A3003A8AAE /* Release */ = {
477479
isa = XCBuildConfiguration;
478480
buildSettings = {
481+
"CODE_SIGN_IDENTITY[sdk=macosx*]" = "Apple Development";
479482
CODE_SIGN_STYLE = Automatic;
480483
CURRENT_PROJECT_VERSION = 1;
484+
DEVELOPMENT_TEAM = 69NPZWZB47;
481485
ENABLE_APP_SANDBOX = YES;
482486
ENABLE_HARDENED_RUNTIME = YES;
483487
ENABLE_USER_SELECTED_FILES = readonly;
@@ -512,9 +516,11 @@
512516
buildSettings = {
513517
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
514518
ASSETCATALOG_COMPILER_GLOBAL_ACCENT_COLOR_NAME = AccentColor;
519+
"CODE_SIGN_IDENTITY[sdk=macosx*]" = "Apple Development";
515520
CODE_SIGN_STYLE = Automatic;
516521
COMBINE_HIDPI_IMAGES = YES;
517522
CURRENT_PROJECT_VERSION = 1;
523+
DEVELOPMENT_TEAM = 69NPZWZB47;
518524
ENABLE_APP_SANDBOX = YES;
519525
ENABLE_HARDENED_RUNTIME = YES;
520526
ENABLE_OUTGOING_NETWORK_CONNECTIONS = YES;
@@ -553,9 +559,11 @@
553559
buildSettings = {
554560
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
555561
ASSETCATALOG_COMPILER_GLOBAL_ACCENT_COLOR_NAME = AccentColor;
562+
"CODE_SIGN_IDENTITY[sdk=macosx*]" = "Apple Development";
556563
CODE_SIGN_STYLE = Automatic;
557564
COMBINE_HIDPI_IMAGES = YES;
558565
CURRENT_PROJECT_VERSION = 1;
566+
DEVELOPMENT_TEAM = 69NPZWZB47;
559567
ENABLE_APP_SANDBOX = YES;
560568
ENABLE_HARDENED_RUNTIME = YES;
561569
ENABLE_OUTGOING_NETWORK_CONNECTIONS = YES;
@@ -592,7 +600,7 @@
592600
/* End XCBuildConfiguration section */
593601

594602
/* Begin XCConfigurationList section */
595-
3FE01093300443A2003A8AAE /* Build configuration list for PBXProject "Pluck Pins" */ = {
603+
3FE01093300443A2003A8AAE /* Build configuration list for PBXProject "Pluck" */ = {
596604
isa = XCConfigurationList;
597605
buildConfigurations = (
598606
3FE010BB300443A3003A8AAE /* Debug */,

safari-app/Pluck/Pluck.xcodeproj/xcshareddata/xcschemes/Pluck (macOS).xcscheme

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<Scheme
33
LastUpgradeVersion = "2600"
4-
version = "1.7">
4+
version = "1.3">
55
<BuildAction
66
parallelizeBuildables = "YES"
77
buildImplicitDependencies = "YES"
@@ -28,6 +28,8 @@
2828
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
2929
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
3030
shouldUseLaunchSchemeArgsEnv = "YES">
31+
<Testables>
32+
</Testables>
3133
</TestAction>
3234
<LaunchAction
3335
buildConfiguration = "Debug"

scripts/package-safari.sh

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ ROOT="$(cd "$(dirname "$0")/.." && pwd)"
55
OUTPUT="${1:-$ROOT/safari-app}"
66
BUNDLE_ID="${BUNDLE_ID:-com.bbrizly.pluck}"
77
APP_NAME="${APP_NAME:-Pluck Pins}"
8+
DEVELOPMENT_TEAM="${DEVELOPMENT_TEAM:-69NPZWZB47}"
89

910
if xcrun --find safari-web-extension-packager >/dev/null 2>&1; then
1011
TOOL="safari-web-extension-packager"
@@ -27,6 +28,19 @@ echo "Safari Xcode project created in: $OUTPUT"
2728
PROJECT=$(find "$OUTPUT" -maxdepth 2 -name '*.xcodeproj' -print -quit 2>/dev/null || true)
2829
if [[ -n "$PROJECT" && "$APP_NAME" == "Pluck Pins" ]]; then
2930
TARGET_BUNDLE_ID="$BUNDLE_ID" /usr/bin/perl -0pi -e 's/PRODUCT_BUNDLE_IDENTIFIER = "?com\.bbrizly\.Pluck-Pins"?;/PRODUCT_BUNDLE_IDENTIFIER = $ENV{TARGET_BUNDLE_ID};/g' "$PROJECT/project.pbxproj"
31+
DEVELOPMENT_TEAM="$DEVELOPMENT_TEAM" /usr/bin/perl -0pi -e '
32+
sub fix_signing {
33+
my ($block) = @_;
34+
return $block unless $block =~ /PRODUCT_BUNDLE_IDENTIFIER = com\.bbrizly\.pluck(?:\.Extension)?;/;
35+
my $team = $ENV{DEVELOPMENT_TEAM};
36+
$block =~ s/DEVELOPMENT_TEAM = [^;]+;/DEVELOPMENT_TEAM = $team;/g;
37+
$block =~ s/"CODE_SIGN_IDENTITY\[sdk=macosx\*\]" = "[^"]+";/"CODE_SIGN_IDENTITY[sdk=macosx*]" = "Apple Development";/g;
38+
$block =~ s/(CODE_SIGN_STYLE = Automatic;\n)/\t\t\t\t"CODE_SIGN_IDENTITY[sdk=macosx*]" = "Apple Development";\n$1/ unless $block =~ /CODE_SIGN_IDENTITY\[sdk=macosx\*\]/;
39+
$block =~ s/(CURRENT_PROJECT_VERSION = [^;]+;\n)/$1\t\t\t\tDEVELOPMENT_TEAM = $team;\n/ unless $block =~ /DEVELOPMENT_TEAM = /;
40+
return $block;
41+
}
42+
s/(buildSettings = \{.*?\n\t\t\t\};)/fix_signing($1)/ges;
43+
' "$PROJECT/project.pbxproj"
3044
RESOURCE_ROOT="$ROOT/extension" \
3145
RESOURCE_ROOT_NO_SLASH="${ROOT#/}/extension" \
3246
TARGET_RESOURCE_PATH="../../../extension" \

0 commit comments

Comments
 (0)