fix(deps): pin mcp SDK below v2 to prevent fresh install crash - #474
Open
syf2211 wants to merge 1 commit into
Open
fix(deps): pin mcp SDK below v2 to prevent fresh install crash#474syf2211 wants to merge 1 commit into
syf2211 wants to merge 1 commit into
Conversation
mcp 2.0 removed decorator-based handlers used by server.py. Cap the dependency at <2 until the project migrates to constructor callbacks. Fixes BeehiveInnovations#470
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pin the MCP Python SDK to
<2so fresh installs no longer resolvemcp2.x and crash at import withAttributeError: 'Server' object has no attribute 'list_tools'.Motivation
pyproject.tomlandrequirements.txtdeclaredmcp>=1.0.0with no upper bound. MCP SDK v2.0.0 removed decorator-based handlers (@server.list_tools(), etc.) thatserver.pystill uses. Fresh installs viauvxorpipnow pull mcp 2.x and fail before the server starts (#470).This is the interim fix recommended by the MCP SDK migration guide until the project migrates to constructor
on_*callbacks.Changes
pyproject.toml:mcp>=1.0.0,<2requirements.txt:mcp>=1.0.0,<2Tests
Notes
pip install .via pyproject and Docker/CI via requirements.txt) are coveredFixes #470