Skip to content

feat: Support PHP 8.5 - #388

Merged
acoulton merged 1 commit into
Behat:masterfrom
acoulton:feat-php85
Nov 3, 2025
Merged

feat: Support PHP 8.5#388
acoulton merged 1 commit into
Behat:masterfrom
acoulton:feat-php85

Conversation

@acoulton

@acoulton acoulton commented Nov 3, 2025

Copy link
Copy Markdown
Contributor

Adds PHP 8.5 to our build matrix and supported versions.

Adds PHP 8.5 to our build matrix and supported versions.
@codecov

codecov Bot commented Nov 3, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.21%. Comparing base (d4a49d0) to head (e3aa5ed).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #388      +/-   ##
============================================
- Coverage     96.30%   96.21%   -0.10%     
  Complexity      664      664              
============================================
  Files            44       44              
  Lines          1977     1902      -75     
============================================
- Hits           1904     1830      -74     
+ Misses           73       72       -1     
Flag Coverage Δ
php8.1 96.21% <ø> (-0.10%) ⬇️
php8.1--with=symfony/yaml:^5.4 96.21% <ø> (-0.10%) ⬇️
php8.1--with=symfony/yaml:^6.4 96.21% <ø> (-0.10%) ⬇️
php8.2 96.21% <ø> (-0.10%) ⬇️
php8.3 96.21% <ø> (-0.10%) ⬇️
php8.4 96.21% <ø> (-0.10%) ⬇️
php8.5 96.21% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acoulton

acoulton commented Nov 3, 2025

Copy link
Copy Markdown
Contributor Author

It's unclear why codecov is seeing a drop in coverage - this is based directly off the last commit in master and has no changes to code or tests... Seems like an issue with codecov AFAICS.

@carlos-granados carlos-granados left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @acoulton

@acoulton
acoulton merged commit 85febc9 into Behat:master Nov 3, 2025
11 of 12 checks passed
@acoulton
acoulton deleted the feat-php85 branch November 3, 2025 17:05
@stof

stof commented Nov 3, 2025

Copy link
Copy Markdown
Member

It looks like some lines containing closing braces (at the end of empty constructors doing only property promotion for instance, or the end of a multiline function call) are not marked as covered anymore while they were before: https://app.codecov.io/gh/Behat/Gherkin/pull/388/indirect-changes

Maybe this is a change in the way XDebug or PHPUnit treats those lines.

@acoulton

acoulton commented Nov 3, 2025

Copy link
Copy Markdown
Contributor Author

Ah yeah, that'd make sense, we'll be on newer phpunit / xdebug versions than the last build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants