feat: Support PHP 8.5 - #388
Conversation
Adds PHP 8.5 to our build matrix and supported versions.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #388 +/- ##
============================================
- Coverage 96.30% 96.21% -0.10%
Complexity 664 664
============================================
Files 44 44
Lines 1977 1902 -75
============================================
- Hits 1904 1830 -74
+ Misses 73 72 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
It's unclear why codecov is seeing a drop in coverage - this is based directly off the last commit in master and has no changes to code or tests... Seems like an issue with codecov AFAICS. |
carlos-granados
left a comment
There was a problem hiding this comment.
Thanks @acoulton
|
It looks like some lines containing closing braces (at the end of empty constructors doing only property promotion for instance, or the end of a multiline function call) are not marked as covered anymore while they were before: https://app.codecov.io/gh/Behat/Gherkin/pull/388/indirect-changes Maybe this is a change in the way XDebug or PHPUnit treats those lines. |
|
Ah yeah, that'd make sense, we'll be on newer phpunit / xdebug versions than the last build. |
Adds PHP 8.5 to our build matrix and supported versions.