Skip to content

Commit 993e01e

Browse files
facontidavideclaude
andcommitted
Revert CI to direct test execution now that thread_local is removed
The ctest approach failed on Windows because gtest_discover_tests runs the test exe from build/tests/ where the DLL path doesn't resolve. Since the root cause (thread_local heap corruption) is now fixed, running the test executable directly works again. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent a80a228 commit 993e01e

2 files changed

Lines changed: 3 additions & 8 deletions

File tree

‎.github/workflows/cmake_windows.yml‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,4 @@ jobs:
4646

4747
- name: Run tests
4848
working-directory: ${{ github.workspace }}/build
49-
# Use ctest to run tests in separate processes, avoiding heap corruption
50-
# issues that occur when all tests run in a single process
51-
run: $env:PATH+=";${{ matrix.build_type }}"; ctest --output-on-failure -C ${{ matrix.build_type }}
49+
run: $env:PATH+=";${{ matrix.build_type }}"; tests/${{ matrix.build_type }}/behaviortree_cpp_test.exe

‎pixi.toml‎

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,10 @@ channels = ["conda-forge"]
77
platforms = ["linux-64", "win-64"]
88

99
[target.win-64.tasks]
10-
# Use ctest to run tests in separate processes, avoiding heap corruption
11-
# issues that occur when all tests run in a single process
12-
test = "PATH=\"$PATH;build/Release\" ctest --test-dir build --output-on-failure -C Release"
10+
test = "PATH=\"$PATH;build/Release\" build/tests/Release/behaviortree_cpp_test.exe"
1311

1412
[target.linux-64.tasks]
15-
# Use ctest to run tests in separate processes for consistency with CI
16-
test = "ctest --test-dir build --output-on-failure"
13+
test = "./build/tests/behaviortree_cpp_test"
1714

1815
[tasks]
1916
build = "mkdir -p build && cd build && cmake ../ -DCMAKE_BUILD_TYPE=Release && cmake --build . --parallel --config Release"

0 commit comments

Comments
 (0)