Skip to content

Commit e12c164

Browse files
committed
cleanup
1 parent 19f9183 commit e12c164

5 files changed

Lines changed: 7 additions & 14 deletions

File tree

‎src/action_node.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ CoroActionNode::CoroActionNode(const std::string& name, const NodeConfig& config
8080
: ActionNodeBase(name, config), _p(new Pimpl)
8181
{}
8282

83-
CoroActionNode::~CoroActionNode() // NOLINT(bugprone-exception-escape)
83+
CoroActionNode::~CoroActionNode()
8484
{
8585
destroyCoroutine();
8686
}

‎src/bt_factory.cpp‎

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -335,9 +335,8 @@ const std::set<std::string>& BehaviorTreeFactory::builtinNodes() const
335335
return _p->builtin_IDs;
336336
}
337337

338-
Tree BehaviorTreeFactory::createTreeFromText(
339-
const std::string& text,
340-
Blackboard::Ptr blackboard) // NOLINT(performance-unnecessary-value-param)
338+
Tree BehaviorTreeFactory::createTreeFromText(const std::string& text,
339+
Blackboard::Ptr blackboard)
341340
{
342341
if(!_p->parser->registeredBehaviorTrees().empty())
343342
{
@@ -354,9 +353,8 @@ Tree BehaviorTreeFactory::createTreeFromText(
354353
return tree;
355354
}
356355

357-
Tree BehaviorTreeFactory::createTreeFromFile(
358-
const std::filesystem::path& file_path,
359-
Blackboard::Ptr blackboard) // NOLINT(performance-unnecessary-value-param)
356+
Tree BehaviorTreeFactory::createTreeFromFile(const std::filesystem::path& file_path,
357+
Blackboard::Ptr blackboard)
360358
{
361359
if(!_p->parser->registeredBehaviorTrees().empty())
362360
{
@@ -374,9 +372,8 @@ Tree BehaviorTreeFactory::createTreeFromFile(
374372
return tree;
375373
}
376374

377-
Tree BehaviorTreeFactory::createTree(
378-
const std::string& tree_name,
379-
Blackboard::Ptr blackboard) // NOLINT(performance-unnecessary-value-param)
375+
Tree BehaviorTreeFactory::createTree(const std::string& tree_name,
376+
Blackboard::Ptr blackboard)
380377
{
381378
auto tree = _p->parser->instantiateTree(blackboard, tree_name);
382379
tree.manifests = this->manifests();

‎src/controls/manual_node.cpp‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,9 +146,7 @@ uint8_t ManualSelectorNode::selectChild() const
146146
initscr();
147147
cbreak();
148148

149-
// NOLINTBEGIN(bugprone-narrowing-conversions,cppcoreguidelines-narrowing-conversions)
150149
win = newwin(static_cast<int>(children_count) + 6, 70, 1, 1); // create a new window
151-
// NOLINTEND(bugprone-narrowing-conversions,cppcoreguidelines-narrowing-conversions)
152150

153151
mvwprintw(win, 0, 0, "Use UP/DOWN arrow to select the child, Enter to confirm.");
154152
mvwprintw(win, 1, 0, "Press: S to skip and return SUCCESSFUL,");

‎src/controls/reactive_fallback.cpp‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
namespace BT
1616
{
1717

18-
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
1918
bool ReactiveFallback::throw_if_multiple_running = false;
2019

2120
void ReactiveFallback::EnableException(bool enable)

‎src/controls/reactive_sequence.cpp‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
namespace BT
1616
{
1717

18-
// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
1918
bool ReactiveSequence::throw_if_multiple_running = false;
2019

2120
void ReactiveSequence::EnableException(bool enable)

0 commit comments

Comments
 (0)