[dvadovsz]

Split out of #1229, as requested in review.

ControlNode::haltChild now resets the child's status before rethrowing an exception from the child's halt(). Previously the child stayed RUNNING, so the next halt of the parent halted it again and threw a second time. When that happened inside ~Tree(), the process terminated. Callers still see the exception. haltChildren() gets the fix through haltChild().

tests/gtest_halt_child.cpp adds a control node that halts its child through haltChild(), with a child whose onHalted() throws. Without the fix the second halt calls onHalted() again and throws, the child is left RUNNING, and the test binary aborts in std::terminate when the tree is destroyed. With the fix it passes.

ControlNode::resetChildren() and DecoratorNode::resetChild() have the same pattern. I left them out to keep this small and can add them here if you prefer.

API/ABI: no signature changes.

[facontidavide]

Thanks @dvadovsz. The bug is real, but haltChild() is the less-used path. Built-in nodes halt their children through ControlNode::halt() → resetChildren() and through DecoratorNode::resetChild(), and Tree::haltTree() halts the root directly. All of them go through TreeNode::haltNode(), and they kept the bug.

I pushed b1a3f86 on top of a merge of master. It moves the guard to that single point (try { halt(); } catch(...) { resetStatus(); throw; }) and removes the now-redundant try/catch from haltChild(), so control_node.cpp is identical to master again. It adds tests with built-in parents (Sequence, RetryUntilSuccessful). With the guard reverted, all three tests fail: onHalted() runs twice and the process ends in std::terminate. Your test is kept. I also changed one static_cast to dynamic_cast for clang-tidy.

There's no ABI change; the edit is .cpp-only. One limit remains: the first throw inside ~Tree() still terminates, because the destructor is implicitly noexcept. That's tracked separately: #1281.

I'll squash-merge once CI is green. #1229 can then drop its copy of the control_node.cpp change.