Repository navigation
null-check the entry in ImportBlackboardFromJSON after createEntry - #1284
Merged
Merged
Conversation
After createEntry() the entry was re-fetched with getEntry() and dereferenced unchecked; a concurrent Blackboard::unset() from another thread in that window returned nullptr and crashed. Skip that key instead. No test: the window is a few instructions wide, so a deterministic reproduction is not possible. The same createEntry->getEntry->deref pattern elsewhere (SetBlackboardNode, script assignment operator) is already null-checked. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ImportBlackboardFromJSON()callscreateEntry(), thengetEntry(), and dereferences the result. A concurrentunset()of the same key from another thread in between makesgetEntry()return nullptr, and the import crashes. Now that key is skipped. This was the only unchecked instance of that pattern;SetBlackboardNodeand the script assignment already check.There's no test, because the race window is too narrow to reproduce deterministically. No ABI change; the edit is .cpp-only.
🤖 Generated with Claude Code