Repository navigation
test: don't assume a tick rate in Reactive.TestLogging - #1285
Merged
Merged
Conversation
The test asserted at least 5 ticks while a 100 ms Sleep runs, i.e. that each 10 ms wait of tickWhileRunning() returns on time. A loaded macOS runner took ~33 ms per wait and failed with 3 ticks (master run 42389941988, 6b8e68c). The test checks that the observer counts match the tick count; the only guaranteed minimum is 2 ticks (one RUNNING, the final SUCCESS). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reactive.TestLoggingasserted at least 5 ticks while a 100 msSleepruns, which assumes each 10 ms wait oftickWhileRunning()returns on time. On a loaded macOS runner each wait took ~33 ms and the test failed 3/3 retries with 3 ticks (master run 42389941988, commit 6b8e68c, a dependabot bump that cannot be the cause).The test checks that the observer's counts match the tick count; the only guaranteed minimum is 2 ticks (one RUNNING, the final SUCCESS). Locally it passes 30/30 under 2× CPU oversubscription; full suite 612/612. Test-only change.
🤖 Generated with Claude Code