Skip to content

test: don't assume a tick rate in Reactive.TestLogging #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
facontidavide merged 1 commit into from
Nov 7, 2026
Merged

test: don't assume a tick rate in Reactive.TestLogging #1285

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/gtest_reactive.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,9 @@ TEST(Reactive, TestLogging)
ASSERT_EQ(ret, NodeStatus::SUCCESS);

int num_ticks = counters[0];
ASSERT_GE(num_ticks, 5);
// At least one RUNNING tick (Sleep) and the final SUCCESS tick. The exact
// count depends on how long each wait takes, which varies on loaded CI runners.
ASSERT_GE(num_ticks, 2);

ASSERT_EQ(observer.getStatistics("testA").success_count, num_ticks);
ASSERT_EQ(observer.getStatistics("success").success_count, num_ticks);
Expand Down
Loading