Repository navigation
Prevent concurrent and reentrant tree halts from interrupting cleanup - #1296
Open
Whathelp233 wants to merge 1 commit into
Open
Whathelp233 wants to merge 1 commit into
Whathelp233 wants to merge 1 commit into
Conversation
Guard the full tree halt so concurrent and reentrant calls cannot interrupt a cleanup callback. Preserve wakeup and exception handling and cover both cases with deterministic regressions.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1295.
When
Finallyis running cleanup during a halt, a secondTree::haltTree()can reach the cleanup child through the fallback traversal. Guard the entire halt using the root node’s private state so concurrent and reentrant calls return before invoking node callbacks. The first call still completes the traversal and wakestickWhileRunning(). The guard is released if a callback throws.Both new regressions fail against the old library and passed 100 consecutive runs each with the fix. All 703 CTest cases passed serially, and pre-commit passed on the changed files.
OpenAI Codex assisted with the implementation and testing.