fix(beldex-explorer): prevent unhandled 500 exceptions and enhance input validation in BNS lookup API - #34
Open
malakasaray-del wants to merge 1 commit into
Conversation
…put validation in BNS lookup API ## Motivation This PR fixes input validation and error-handling vulnerabilities in the `beldex-explorer` repository (`explorer.py`), identified during the Beldex workspace security audit[cite: 36]. Previously, omitting the required `name` query parameter on the `/api/bnslookup` endpoint resulted in an unhandled AttributeError leading to a 500 internal server error stack trace disclosure[cite: 36]. Additionally, unbounded string inputs lacked strict length controls before being processed[cite: 36]. ## Modifications * **Robust Input Validation (`explorer.py`)**: * Added missing query parameter checks on `/api/bnslookup` to safely abort with an explicit HTTP 400 status instead of triggering unhandled server exceptions[cite: 36]. * Enforced a strict length ceiling (maximum 256 characters) on the `name` query parameter to prevent unbounded payload processing[cite: 36]. ## Checklist - [x] Format your code according to the Contributor Guide. - [ ] Add unit tests as outlined in the Contributor Guide. - [x] Update documentation as needed, including docstrings or example tutorials. ```[cite: 36]
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR fixes input validation and error-handling vulnerabilities in the
beldex-explorerrepository (explorer.py), identified during the Beldex workspace security audit[cite: 36]. Previously, omitting the requirednamequery parameter on the/api/bnslookupendpoint resulted in an unhandled AttributeError leading to a 500 internal server error stack trace disclosure[cite: 36]. Additionally, unbounded string inputs lacked strict length controls before being processed[cite: 36].Modifications
explorer.py):/api/bnslookupto safely abort with an explicit HTTP 400 status instead of triggering unhandled server exceptions[cite: 36].namequery parameter to prevent unbounded payload processing[cite: 36].Checklist