Spelling - #210
Open
jsoref wants to merge 12 commits into
Open
Conversation
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
jsoref
commented
Nov 9, 2022
jsoref
left a comment
jsoref
left a comment
Author
There was a problem hiding this comment.
Most corrections automatically suggested by Google Sheets. All fault mine.
| * Prefers composition over inheritance | ||
| * Dependency Injection is implemented via `provider` | ||
| * Prefers `StatelessWidget` and async UI update via `StreamBuidler` and `BehaviourSubject` & `StreamController` in controller classes | ||
| * Prefers `StatelessWidget` and async UI update via `StreamBuilder` and `BehaviourSubject` & `StreamController` in controller classes |
Author
There was a problem hiding this comment.
Some projects don't like changing changelogs. Happy to drop this or any other change.
| Link multi-module project dependencies | ||
|
|
||
| `fvm pub global activaite melos` | ||
| `fvm pub global activate melos` |
| flutter pub global run tuneup stats | ||
| description: | | ||
| Display packages code/fiels stats | ||
| Display packages code/file stats |
Author
There was a problem hiding this comment.
This could be fields, files, or file. Google Sheets guessed the first one...
| run: | | ||
| melos run fastlane:frameit:metadata:text --no-select && \ | ||
| melos run fastlane:frameit:metadata:screenshtos --no-select | ||
| melos run fastlane:frameit:metadata:screenshots --no-select |
| "app_about_learnMore": MessageLookupByLibrary.simpleMessage("Детали"), | ||
| "app_about_title": MessageLookupByLibrary.simpleMessage("О Fedi"), | ||
| "app_acccount_my_customList_edit_account_action_add": | ||
| "app_account_my_customList_edit_account_action_add": |
Author
There was a problem hiding this comment.
Some projects don't like changing localizations. (Others request it, it's about 50/50, and I generally guess wrong.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corrects misspellings identified by the check-spelling action.
The misspellings have been reported at jsoref@7c5dcd5#commitcomment-89322911
The action reports that the changes in this PR would make it happy: jsoref@21ae9ff
Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.