Skip to content

Commit ed32fe8

Browse files
committed
plans: mark section 6 verification complete
All five verification sub-steps re-run in the devcontainer on 2026-05-23 and confirmed passing: tool restore, regenerateInsdcTypes, default buildSolution (0 errors, no CS1591), runtests (24/24), pack (both nupkgs produced). Noted that the Pack target's interactive Y/n prompt requires piping 'echo Y' when run non-interactively.
1 parent d049bc3 commit ed32fe8

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

‎plans/implementation.md‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -152,15 +152,15 @@ The `regenerateInsdcTypes` target lives in `build/BasicTasks.fs`. It is standalo
152152

153153
CI uses `global-json-file: global.json` so the workflow tracks the SDK version pinned at the repo root (currently 10.0.100). The Codecov slug is retargeted to `BioFSharp/BioFSharp.INSDC`.
154154

155-
## 6. [ ] Verification
155+
## 6. [x] Verification
156156

157157
Each step gates the next:
158158

159-
1. `dotnet tool restore` succeeds.
160-
2. `build.cmd regenerateInsdcTypes` produces `.cs` files under `src/BioFSharp.FileFormats.INSDC/Generated/`.
161-
3. `build.cmd` (default `buildSolution`) succeeds with zero `CS1591` (missing-XML-doc) warnings.
162-
4. [x] `bash build.sh runtests` passes locally in the devcontainer (`24/24` tests, 2026-05-21).
163-
5. `build.cmd pack` produces both nupkgs with non-template metadata.
159+
1. [x] `dotnet tool restore` succeeds (verified 2026-05-23 in devcontainer; restores `dotnet-xscgen` 3.0.1270 and `fsdocs-tool` 20.0.1).
160+
2. [x] `build.sh regenerateInsdcTypes` produces `.cs` files under `src/BioFSharp.FileFormats.INSDC/Generated/` (verified 2026-05-23; only diff vs. committed output is the absolute-path noise in the generator-header comment).
161+
3. [x] `build.sh` (default `buildSolution`) succeeds with zero `CS1591` (missing-XML-doc) warnings (verified 2026-05-23; `0 Error(s)`).
162+
4. [x] `bash build.sh runtests` passes locally in the devcontainer (`24/24` tests, re-confirmed 2026-05-23).
163+
5. [x] `build.sh pack` produces both nupkgs with non-template metadata (verified 2026-05-23 — `pkg/BioFSharp.FileFormats.INSDC.0.1.0.nupkg` and `pkg/BioFSharp.IO.INSDC.0.1.0.nupkg`). The `Pack` target uses an interactive `Y/n` confirmation prompt; pipe `echo Y |` when invoking non-interactively.
164164

165165
## 7. Out of scope
166166

0 commit comments

Comments
 (0)