Repository navigation
Let ImageJ edits show up in BigDataViewer - #148
Merged
Merged
Conversation
stefanhahmann
force-pushed
the
unmerge-rgb-channels
branch
from
October 6, 2026 12:12
93ba12b to
8e59371
Compare
ImageJ merged them into one RGB image on a read-only virtual stack. Now each channel is a writable plane. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
stefanhahmann
force-pushed
the
unmerge-rgb-channels
branch
from
October 6, 2026 12:18
8e59371 to
7ba0fc8
Compare
stefanhahmann
changed the title
|
xulman
approved these changes
Oct 8, 2026
xulman
left a comment
xulman
left a comment
Contributor
There was a problem hiding this comment.
This is indeed a nice fix, many thanks for it.
It was an unfortunate omission that we allowed Fiji to mess with the channels and interpert them. Also the test is very nice as it is using BDV's internal own rendering machine to read out what it has rendered-out, and thus to test what goes on the screen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An OME-Zarr opened in ImageJ via Open Current OME-Zarr Image in ImageJ... shares its cell images with
BigDataViewer, so edits in ImageJ show up in BDV — once ImageJ leaves the edited plane and BDV redraws.
OmeZarrTest#rectangleFilledInImageJIsRenderedInBdv(both backends): fills a ROI in ImageJ and checks an offscreen BDV render.PyramidalDatasetcallssetRGBMerged( false ): ImageJ opened 3-channel uint8 images as RGB on a read-only virtual stack, so edits never reached the cell images in these cases. They now open as 3-channel composites.For the reviewer: truly RGB data (e.g. brightfield from bioformats2raw) now opens as a composite, so
RGB-only tools such as Colour Deconvolution stop working on it. Is that acceptable, or should we keep
RGB=trueand have the test switch off the merge on its own inPyramidalDataset?🤖 Generated with Claude Code