Switch to onedir build to fix python311.dll load error

Inno Setup now bundles the full dist folder, portable version is zipped

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: Paullux

.github/workflows/build.yml

@@ -34,11 +34,14 @@ jobs:
           mkdir installer\installer_output
           & "C:\Program Files (x86)\Inno Setup 6\ISCC.exe" installer\MusicPresence.iss
 
-      - name: Upload portable exe
+      - name: Zip portable
+        run: Compress-Archive -Path dist\MusicPresence\* -DestinationPath dist\MusicPresence-portable.zip
+
+      - name: Upload portable
         uses: actions/upload-artifact@v4
         with:
           name: MusicPresence-windows-portable
-          path: dist/MusicPresence.exe
+          path: dist/MusicPresence-portable.zip
 
       - name: Upload installer
         uses: actions/upload-artifact@v4
@@ -157,6 +160,6 @@ jobs:
             > Placez votre fichier `.env` dans le même dossier que l'exécutable.
           files: |
             artifacts/MusicPresence-windows-setup/MusicPresence-Setup-*.exe
-            artifacts/MusicPresence-windows-portable/MusicPresence.exe
+            artifacts/MusicPresence-windows-portable/MusicPresence-portable.zip
             artifacts/MusicPresence-linux-appimage/MusicPresence-*.AppImage
             artifacts/MusicPresence-linux-binary/MusicPresence

MusicPresence.spec

@@ -22,7 +22,6 @@ hiddenimports_common = [
     'updater',
     'ui.update_dialog',
     'ui.notify',
-    'winotify',
     'packaging',
     'packaging.version',
 ]
@@ -31,7 +30,8 @@ hiddenimports_windows = [
     'winsdk.windows.media.control',
     'winsdk.windows.storage.streams',
     'winsdk.windows.foundation',
-]
+    'winotify',
+] + winsdk_hiddenimports
 
 hiddenimports_linux = [
     'dbus',
@@ -50,7 +50,7 @@ a = Analysis(
         ('playersIcons', 'playersIcons'),
         ('assets', 'assets'),
     ] + winsdk_datas,
-    hiddenimports=hiddenimports + winsdk_hiddenimports,
+    hiddenimports=hiddenimports,
     hookspath=[],
     hooksconfig={},
     runtime_hooks=[],
@@ -66,21 +66,24 @@ pyz = PYZ(a.pure, a.zipped_data, cipher=block_cipher)
 exe = EXE(
     pyz,
     a.scripts,
-    a.binaries,
-    a.zipfiles,
-    a.datas,
     [],
+    exclude_binaries=True,
     name='MusicPresence',
     debug=False,
     bootloader_ignore_signals=False,
     strip=False,
     upx=True,
-    upx_exclude=[],
-    runtime_tmpdir=None,
-    icon='assets/icon.ico',
     console=False,
-    disable_windowed_traceback=False,
-    target_arch=None,
-    codesign_identity=None,
-    entitlements_file=None,
+    icon='assets/icon.ico',
+)
+
+coll = COLLECT(
+    exe,
+    a.binaries,
+    a.zipfiles,
+    a.datas,
+    strip=False,
+    upx=True,
+    upx_exclude=[],
+    name='MusicPresence',
 )

installer/MusicPresence.iss

@@ -33,7 +33,7 @@ Name: "desktopicon"; Description: "{cm:CreateDesktopIcon}"; GroupDescription: "{
 Name: "startupicon"; Description: "Launch at Windows startup"; GroupDescription: "Startup"
 
 [Files]
-Source: "..\dist\{#MyAppExeName}"; DestDir: "{app}"; Flags: ignoreversion
+Source: "..\dist\MusicPresence\*"; DestDir: "{app}"; Flags: ignoreversion recursesubdirs createallsubdirs
 
 [Icons]
 Name: "{group}\{#MyAppName}"; Filename: "{app}\{#MyAppExeName}"