test(uniswap): restore mandatory liquidity evidence

Author: BitHighlander

.circleci/config.yml

@@ -32,7 +32,7 @@ jobs:
             # Actions integration lane. Bump deliberately with that workflow.
             git init .
             git remote add origin https://github.com/BitHighlander/keepkey-firmware.git
-            git fetch --depth 1 origin ec9ced7f23b119878961ee6571da29b035cf11fb
+            git fetch --depth 1 origin 54b169a7036b29db22944d962fb666b50aef9083
             git checkout --detach FETCH_HEAD
 
             # Initialise firmware submodules

.github/workflows/ci.yml

@@ -130,7 +130,7 @@ jobs:
           # integration-btc job) and the Ironwood known-answer vectors. So this
           # job validates 7.16.0; it does not validate the RC18 dependency
           # graph. Bump deliberately, and re-read that claim when you do.
-          ref: ec9ced7f23b119878961ee6571da29b035cf11fb
+          ref: 54b169a7036b29db22944d962fb666b50aef9083
           path: keepkey-firmware
 
       # NOT `submodules: recursive`. trezor-firmware carries a micropython

scripts/generate-test-report.py

@@ -1138,21 +1138,25 @@ def _arg_shown(a):
           'Failure on the wire.',
           []),
          ('E17', 'test_msg_ethereum_erc20_uniswap_liquidity', 'test_sign_uni_approve_liquidity_ETH',
-          'Uniswap V2 add-liquidity approve (pending)',
-          'PENDING, disclosed: known emulator limitation — an approve to an unknown (non-registry) '
-          'token contract cannot complete against the kkemu emulator (matches the sibling '
-          'add/remove-liquidity skips below); the device-firmware path is not in question, only '
-          'CI emulator coverage. Real-device testing is unaffected.',
-          []),
+          'Uniswap V2 LP-token approval',
+          'Approves the Uniswap V2 FOX/WETH LP token for the canonical router. The exact pool '
+          'identity and full-LP allowance are shown before the generic fee review, and the fixed '
+          'signature proves the reviewed transaction bytes are the bytes signed.',
+          ['Full LP allowance', 'LP token and pool address', 'Fee and final approval']),
          ('E18', 'test_msg_ethereum_erc20_uniswap_liquidity', 'test_sign_uni_add_liquidity_ETH',
-          'Uniswap V2 add liquidity ETH+token (pending)',
-          'PENDING, disclosed: same emulator limitation as E17 — a daily-driver LP-deposit flow '
-          'with no PDF proof on this build; tracked for real-device verification.',
-          []),
+          'Uniswap V2 add liquidity ETH+token',
+          'Clear-signs both desired/minimum FOX and ETH amounts, the signed recipient, and the '
+          'deadline before the final fee review. The fixed signature binds those confirmations '
+          'to the complete addLiquidityETH calldata.',
+          ['FOX desired amount', 'FOX minimum', 'Recipient', 'ETH desired amount',
+           'ETH minimum', 'Deadline', 'Fee and final approval']),
          ('E19', 'test_msg_ethereum_erc20_uniswap_liquidity', 'test_sign_uni_remove_liquidity_ETH',
-          'Uniswap V2 remove liquidity ETH+token (pending)',
-          'PENDING, disclosed: same emulator limitation as E17.',
-          []),
+          'Uniswap V2 remove liquidity ETH+token',
+          'Clear-signs the LP burn amount, minimum FOX and ETH outputs, the non-self signed '
+          'recipient, and deadline before the final fee review. This is the regression for the '
+          'recipient-confirmation path that previously cancelled after the user approved it.',
+          ['LP burn amount', 'FOX minimum', 'Recipient', 'ETH minimum', 'Deadline',
+           'Fee and final approval']),
          ('E20', 'test_msg_ethereum_thorchain_deposit', 'test_deposit_legacy_selector',
           'THORChain router deposit() (legacy selector)',
           'Cross-chain swap via the THORChain router contract — a daily-driver EVM<->THORChain '

tests/test_msg_ethereum_erc20_uniswap_liquidity.py

@@ -27,24 +27,6 @@
 
 class TestMsgEthereumUniswaptxERC20(common.KeepKeyTest):
 
-    def setUp(self):
-        super(TestMsgEthereumUniswaptxERC20, self).setUp()
-        # Every test in this file approves or spends against the ETH/FOX pool,
-        # whose contract is NOT in the token table. Approving an unknown token
-        # contract does not complete on the emulator: the device never returns,
-        # so these tests HANG instead of failing, and CI kills the whole run on
-        # its no-output timeout -- taking every later test with it.
-        #
-        # This is a firmware-side limitation, not a gap in the tests. It is
-        # gated here rather than deleted so the coverage returns automatically
-        # once the firmware completes this path. Known-token approves
-        # (test_msg_ethereum_erc20_approve) run here and pass; on real hardware
-        # this path is exercised by the app.
-        if self.client.features.firmware_variant[0:8] == "Emulator":
-            self.skipTest(
-                "Uniswap liquidity against an unknown token contract does not "
-                "complete on the emulator")
-    
     def test_sign_uni_approve_liquidity_ETH(self):
         self.requires_fullFeature()
         self.requires_firmware("7.1.0")