Skip to content

Commit d404ea9

Browse files
committed
test(ci): align retired Binance and corrected EOS vectors
1 parent 91a0334 commit d404ea9

4 files changed

Lines changed: 17 additions & 6 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ jobs:
130130
# integration-btc job) and the Ironwood known-answer vectors. So this
131131
# job validates 7.16.0; it does not validate the RC18 dependency
132132
# graph. Bump deliberately, and re-read that claim when you do.
133-
ref: a710bb5777f3ad888bb489b383dbafab800d55c6
133+
ref: 6d5e1917b7cc80a5b84a6ec79c82cffef3aab4c9
134134
path: keepkey-firmware
135135

136136
# NOT `submodules: recursive`. trezor-firmware carries a micropython

scripts/generate-test-report.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -564,10 +564,6 @@ def _arg_shown(a):
564564
'domain name. The feature is withdrawn rather than shipped with a screen it could not '
565565
'vouch for: zero screens, refusal on the wire.',
566566
[]),
567-
('J11', 'test_msg_binance_sign_tx', 'test_transfer',
568-
'Binance denom renders in full',
569-
'A long denom must render completely and must not overflow the formatting buffer.',
570-
['Transfer screen showing the full denom']),
571567
('J12', 'test_msg_ping', 'test_ping_long_body_is_paged',
572568
'A long body is paged, not clipped',
573569
'A body that will not fit one screen is shown across several, with the page number '

tests/test_msg_binance_sign_tx.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,11 @@
2626
class TestMsgBinanceSignTx(common.KeepKeyTest):
2727

2828
def setup_binance(self):
29+
# Native Binance Beacon Chain signing was deliberately removed from
30+
# firmware (#541). Keep these vectors useful for older firmware, but
31+
# do not treat an unregistered message on current builds as a signing
32+
# regression.
33+
self.requires_message("BinanceSignTx")
2934
self.client.load_device_by_mnemonic(
3035
mnemonic="offer caution gift cross surge pretty orange during eye soldier popular holiday mention east eight office fashion ill parrot vault rent devote earth cousin",
3136
pin=self.pin4,

tests/test_msg_eos_signtx.py

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -568,7 +568,17 @@ def test_updateauth(self):
568568
num_actions=1),
569569
[self.action_updateauth(True)])
570570

571-
self.assertEqual(binascii.hexlify(res.hash), "fb936ef1be4bda680d93bd10b6d062357d8dd7272038a706dc0d61a91f39c5ee")
571+
# Firmware #568 (7.16.0) fixed eos_hashAuthorization() to serialize
572+
# waits_count entries, not accounts_count entries. This SLIP-48 vector
573+
# has one delegated account and zero waits; the old golden committed a
574+
# phantom zero wait that was neither present nor confirmed on-device.
575+
version = (self.client.features.major_version,
576+
self.client.features.minor_version,
577+
self.client.features.patch_version)
578+
expected = ("5938294e65cf9e8b5dd5f2b204503b4825f277e6f4a2d5ab7a55a31065a23af1"
579+
if version >= (7, 16, 0)
580+
else "fb936ef1be4bda680d93bd10b6d062357d8dd7272038a706dc0d61a91f39c5ee")
581+
self.assertEqual(binascii.hexlify(res.hash), expected)
572582

573583
def test_deleteauth(self):
574584
self.requires_fullFeature()

0 commit comments

Comments
 (0)