Skip to content

Commit d9ab7fd

Browse files
committed
remove(binance): delete the stale Binance Chain SignTx test, unblocking python-integration-tests
Firmware deleted the Binance Chain (Beacon Chain, a dead chain) signing path in keepkey-firmware@45cbc13dc -- all fsm.c handlers and every messagemap.def MSG_IN/MSG_OUT registration for BinanceGetAddress/SignTx/TransferMsg. This test suite never actually ran in CI until now (keepkey-firmware's secret-scan was silently skipping the entire build/test graph on every PR -- see keepkey-firmware#583), so nobody caught that the corresponding test file was never removed to match. test_msg_binance_sign_tx.py's two tests (test_transfer, test_transfer_bep2) send BinanceSignTx against a firmware build that no longer registers a handler for it and correctly refuse with Failure_UnexpectedMessage instead of a signed response -- a real, expected consequence of the removal, not a signing regression. Also drops the SECTIONS report's stale J11 entry, which reused this test as its evidence for a generic 'long denom renders in full' formatting claim -- unrelated to Binance specifically, but its only vehicle no longer exists. The existing 'Tests remain in python-keepkey but excluded from report' comment above the O section shows this cleanup was already done once for the dedicated Binance section; this entry was the one cross- reference that cleanup missed.
1 parent b4f5f0e commit d9ab7fd

2 files changed

Lines changed: 0 additions & 112 deletions

File tree

scripts/generate-test-report.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -564,10 +564,6 @@ def _arg_shown(a):
564564
'domain name. The feature is withdrawn rather than shipped with a screen it could not '
565565
'vouch for: zero screens, refusal on the wire.',
566566
[]),
567-
('J11', 'test_msg_binance_sign_tx', 'test_transfer',
568-
'Binance denom renders in full',
569-
'A long denom must render completely and must not overflow the formatting buffer.',
570-
['Transfer screen showing the full denom']),
571567
('J12', 'test_msg_ping', 'test_ping_long_body_is_paged',
572568
'A long body is paged, not clipped',
573569
'A body that will not fit one screen is shown across several, with the page number '

tests/test_msg_binance_sign_tx.py

Lines changed: 0 additions & 108 deletions
This file was deleted.

0 commit comments

Comments
 (0)