Commit d9ab7fd
committed
remove(binance): delete the stale Binance Chain SignTx test, unblocking python-integration-tests
Firmware deleted the Binance Chain (Beacon Chain, a dead chain) signing
path in keepkey-firmware@45cbc13dc -- all fsm.c handlers and every
messagemap.def MSG_IN/MSG_OUT registration for
BinanceGetAddress/SignTx/TransferMsg. This test suite never actually ran
in CI until now (keepkey-firmware's secret-scan was silently skipping the
entire build/test graph on every PR -- see keepkey-firmware#583), so
nobody caught that the corresponding test file was never removed to
match.
test_msg_binance_sign_tx.py's two tests (test_transfer, test_transfer_bep2)
send BinanceSignTx against a firmware build that no longer registers a
handler for it and correctly refuse with Failure_UnexpectedMessage instead
of a signed response -- a real, expected consequence of the removal, not a
signing regression.
Also drops the SECTIONS report's stale J11 entry, which reused this test
as its evidence for a generic 'long denom renders in full' formatting
claim -- unrelated to Binance specifically, but its only vehicle no longer
exists. The existing 'Tests remain in python-keepkey but excluded from
report' comment above the O section shows this cleanup was already done
once for the dedicated Binance section; this entry was the one cross-
reference that cleanup missed.1 parent b4f5f0e commit d9ab7fd
2 files changed
Lines changed: 0 additions & 112 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
564 | 564 | | |
565 | 565 | | |
566 | 566 | | |
567 | | - | |
568 | | - | |
569 | | - | |
570 | | - | |
571 | 567 | | |
572 | 568 | | |
573 | 569 | | |
| |||
This file was deleted.
0 commit comments