chore(consideratecoder): ruff/mypy を配線し診断を 0 にする、ruff format を適用

方法論を配る側が自分の検証コードを検めていないのは筋が通らない。本プラグインの
実体は skills/ と commands/ の Markdown で、Python は tests/ の 4 本だけだが、
それらは「方法論どおりに書いた実装例が実際に通るか」を検める検証コードである。

pyproject.toml を新設（`[project]` / `[build-system]` は置かない——配布物ではなく
設定を読む場所として要るだけ）。規約は和集合: select 10 集合 ＋ mypy strict。

- lint 2 件: E741（`l` → `line`）
- mypy strict 57 → 0: 35 件は `-> None` の付与（AST 判定で機械的に）、
  `_split_frontmatter` / `_outsource_phase{4,5}_region` の 4 本を型付けすると
  no-untyped-call 17 件が連鎖で消えた
- **`union-attr` 1 件は実バグ手前だった** —— `re.search(...).group(1)` は
  search が None を返すと AttributeError になる。match を束ねて assert を挟み、
  「tools: 行が在ること」というテストの意図をコードに書いた
- ruff format 4 files

検証: ruff All checks passed / mypy Success (4 source files) / pytest 35 passed

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Author: web-flow

ConsiderateCoder/pyproject.toml

@@ -0,0 +1,23 @@
+# ConsiderateCoder の開発ツール設定。
+#
+# `[project]` / `[build-system]` は意図的に置かない —— 本プラグインの実体は
+# skills/ と commands/ の Markdown（開発方法論）で、Python は tests/ の 4 本だけ。
+# それらは「方法論どおりに書いた実装例が実際に通るか」を検める検証コードであり、
+# 配布物ではない。ここが要るのは ruff / mypy / pytest が設定を読む場所としてだけ。
+#
+# 規約はワークスペースの和集合（2026-08-25 確定）: ruff の select は広く取り、
+# mypy は strict。方法論を配る側が自分の検証コードを検めていないのは筋が通らない。
+
+[tool.ruff]
+src = ["tests"]
+
+[tool.ruff.lint]
+# ruff の default 選択は版が上がるたび広がるので明示固定する。集合は
+# BlueberrySprite / NewsCaster / GeneralConstructor / ContextPreloader と同一の 10 個。
+select = ["E4", "E7", "E9", "F", "I", "UP", "N", "B", "SIM", "PTH"]
+
+[tool.mypy]
+strict = true
+
+[tool.pytest.ini_options]
+testpaths = ["tests"]

ConsiderateCoder/tests/test_stage1_domain.py

@@ -4,6 +4,7 @@
 generalized (no workspace-specific tokens leaked from the source copy).
 Stdlib only: json / re / pathlib. No external dependencies, no conftest.
 """
+
 import json
 import re
 from pathlib import Path
@@ -20,7 +21,7 @@
 ]
 
 
-def test_plugin_manifest():
+def test_plugin_manifest() -> None:
     manifest_path = PLUGIN_ROOT / ".claude-plugin" / "plugin.json"
     assert manifest_path.exists(), f"missing {manifest_path}"
 
@@ -43,7 +44,7 @@ def test_plugin_manifest():
 )
 
 
-def test_rule_skills_exist_and_generic():
+def test_rule_skills_exist_and_generic() -> None:
     """Both rule skills exist with skill frontmatter (name/description) and
     carry no workspace-specific tokens."""
     for path in RULE_SKILLS:
@@ -58,7 +59,7 @@ def test_rule_skills_exist_and_generic():
             assert token not in text, f"{path.name} contains forbidden token: {token!r}"
 
 
-def test_dev_rules_latest_and_self_contained():
+def test_dev_rules_latest_and_self_contained() -> None:
     """dev-rules carries the CI static-check line (stale-copy regression
     check) and must be self-contained: subagents do not receive the full
     Claude Code system prompt, so the rules may not defer to it."""
@@ -76,7 +77,7 @@ def test_dev_rules_latest_and_self_contained():
     )
 
 
-def test_dev_rules_deletion_test_and_grounded_numbers():
+def test_dev_rules_deletion_test_and_grounded_numbers() -> None:
     """dev-rules operationalizes YAGNI at both ends: the Deletion Test
     inspects finished work ("does the completion proof still hold without
     this?") with a non-negotiable floor (validation / error handling /
@@ -89,15 +90,15 @@ def test_dev_rules_deletion_test_and_grounded_numbers():
         assert token in text, f"dev-rules missing rule token: {token!r}"
 
 
-def test_dev_rules_solution_ladder_in_understand():
+def test_dev_rules_solution_ladder_in_understand() -> None:
     """The solution-search ladder (don't write → reuse → stdlib → existing
     dependency → minimal new code) must sit inside the Understand step in
     close (same or <=3 line) proximity, so search-first reads as part of
     the flow rather than a detached slogan (same proximity pattern as the
     Stage 3 policy tests)."""
     lines = RULE_SKILLS[0].read_text(encoding="utf-8").splitlines()
-    ladder_idxs = [i for i, l in enumerate(lines) if "標準ライブラリ" in l]
-    understand_idxs = [i for i, l in enumerate(lines) if "Understand" in l]
+    ladder_idxs = [i for i, line in enumerate(lines) if "標準ライブラリ" in line]
+    understand_idxs = [i for i, line in enumerate(lines) if "Understand" in line]
     assert ladder_idxs, "dev-rules missing the solution ladder (標準ライブラリ step)"
     assert understand_idxs, "dev-rules missing the Understand step"
     assert any(abs(a - b) <= 3 for a in ladder_idxs for b in understand_idxs), (

ConsiderateCoder/tests/test_stage2_usecase.py

@@ -5,6 +5,7 @@
 evidence references (dates, proof counts, local-environment paths).
 Stdlib only: re / pathlib. No external dependencies, no conftest.
 """
+
 import re
 from pathlib import Path
 
@@ -26,15 +27,15 @@
 DATE_PATTERN = re.compile(r"20\d\d-\d\d")
 
 
-def _split_frontmatter(path):
+def _split_frontmatter(path: Path) -> tuple[str, str, str]:
     assert path.exists(), f"missing {path}"
     text = path.read_text(encoding="utf-8")
     m = FRONTMATTER_RE.match(text)
     assert m, f"{path.name}: frontmatter delimiters (---) not found"
     return m.group(1), m.group(2), text
 
 
-def test_agent_frontmatter():
+def test_agent_frontmatter() -> None:
     """Both agents declare name/description/model; orchestrator's tools
     line excludes Edit/Write (structural guarantee: the commander cannot
     touch files directly). Word-boundary matching avoids false positives
@@ -59,7 +60,7 @@ def test_agent_frontmatter():
     )
 
 
-def test_orchestrator_references_namespaced_worker():
+def test_orchestrator_references_namespaced_worker() -> None:
     """orchestrator body must delegate via the namespaced worker
     (ConsiderateCoder:worker); a bare `subagent_type: worker` would not
     resolve once the agent is installed as a plugin.
@@ -74,31 +75,29 @@ def test_orchestrator_references_namespaced_worker():
     )
 
 
-def test_structural_tool_guarantees():
+def test_structural_tool_guarantees() -> None:
     """Structural guarantees on both sides of the delegation: the
     orchestrator cannot send async messages (no SendMessage — its own
     discipline bans round-trips), and the worker cannot re-delegate
     (Agent is disallowed). Discipline is culture; the tool list is law."""
     orchestrator_fm, _, _ = _split_frontmatter(ORCHESTRATOR_PATH)
-    tools_line = re.search(
-        r"^tools:\s*(.+)$", orchestrator_fm, re.MULTILINE
-    ).group(1)
+    tools_match = re.search(r"^tools:\s*(.+)$", orchestrator_fm, re.MULTILINE)
+    assert tools_match, "orchestrator frontmatter has no tools: line"
+    tools_line = tools_match.group(1)
     assert not re.search(r"\bSendMessage\b", tools_line), (
         f"orchestrator tools must not include SendMessage: {tools_line!r}"
     )
 
     worker_fm, _, _ = _split_frontmatter(WORKER_PATH)
-    disallowed_match = re.search(
-        r"^disallowedTools:\s*(.+)$", worker_fm, re.MULTILINE
-    )
+    disallowed_match = re.search(r"^disallowedTools:\s*(.+)$", worker_fm, re.MULTILINE)
     assert disallowed_match, "worker frontmatter missing disallowedTools line"
     assert re.search(r"\bAgent\b", disallowed_match.group(1)), (
         f"worker disallowedTools must include Agent (no re-delegation): "
         f"{disallowed_match.group(1)!r}"
     )
 
 
-def test_agents_preload_dev_rules():
+def test_agents_preload_dev_rules() -> None:
     """Both agents preload dev-rules via the skills: frontmatter field —
     the official wiring that injects full rule content into a subagent's
     context at spawn (subagents don't receive the full Claude Code system
@@ -108,15 +107,14 @@ def test_agents_preload_dev_rules():
         skills_match = re.search(r"^skills:\s*(.+)$", frontmatter, re.MULTILINE)
         assert skills_match, f"{path.name} missing skills: preload line"
         assert "dev-rules" in skills_match.group(1), (
-            f"{path.name} skills: must preload dev-rules: "
-            f"{skills_match.group(1)!r}"
+            f"{path.name} skills: must preload dev-rules: {skills_match.group(1)!r}"
         )
 
 
 STATUS_VOCAB = ("COMPLETED", "PARTIAL", "BLOCKED", "RETURNED")
 
 
-def test_completion_status_vocabulary_symmetric():
+def test_completion_status_vocabulary_symmetric() -> None:
     """The worker report opens with a one-word completion status, and a stop
     (3-Strike STOP / interruption / unverified work) is never written as
     COMPLETED; the orchestrator briefs and reviews with the same four-state
@@ -133,17 +131,15 @@ def test_completion_status_vocabulary_symmetric():
     )
 
 
-def test_worker_reports_discovered_issues():
+def test_worker_reports_discovered_issues() -> None:
     """Out-of-scope problems the worker notices must reach the report:
     staying hands-off is required, staying silent is forbidden (discovering
     an issue and not reporting it reads as a clean pass to the reviewer)."""
     _, body, _ = _split_frontmatter(WORKER_PATH)
-    assert "黙過" in body, (
-        "worker.md missing the no-silent-discovery rule (黙過)"
-    )
+    assert "黙過" in body, "worker.md missing the no-silent-discovery rule (黙過)"
 
 
-def test_no_dev_evidence_refs():
+def test_no_dev_evidence_refs() -> None:
     """Neither agent may carry development-session evidence: dates,
     proof-count callouts, local model assumptions, or local paths.
     """