fix(demo,nestjs-notifications): resolve e2e test warnings and enforce auth

- Replace deprecated package.json#prisma config with prisma.config.ts
- Remove deprecated prismaSchemaFolder preview feature from base.prisma
- Register JwtAuthGuard as global APP_GUARD so protected routes require auth
- Add conditional BullMQ queue providers in notification module async path
  to fix "Email queue is not available" errors
- Update e2e tests to expect 401 on unauthenticated protected routes
  and clean 200 on notification preferences PUT

Author: JonatanSalas

apps/demo/package.json

@@ -44,9 +44,6 @@
     "reflect-metadata": "^0.2.0",
     "rxjs": "^7.8.0"
   },
-  "prisma": {
-    "schema": "prisma/schema"
-  },
   "devDependencies": {
     "@nestjs/cli": "^10.0.0",
     "@nestjs/schematics": "^10.0.0",

apps/demo/prisma.config.ts

@@ -0,0 +1,9 @@
+import path from 'node:path';
+import { defineConfig } from 'prisma/config';
+import dotenv from 'dotenv';
+
+dotenv.config();
+
+export default defineConfig({
+  schema: path.join(__dirname, 'prisma', 'schema'),
+});

apps/demo/prisma/schema/base.prisma

@@ -1,6 +1,5 @@
 generator client {
-  provider        = "prisma-client-js"
-  previewFeatures = ["prismaSchemaFolder"]
+  provider = "prisma-client-js"
 }
 
 datasource db {

apps/demo/src/app.module.ts

@@ -1,8 +1,9 @@
 import { Module } from '@nestjs/common';
+import { APP_GUARD } from '@nestjs/core';
 import { ConfigModule, ConfigService } from '@nestjs/config';
 import { EventEmitterModule } from '@nestjs/event-emitter';
 import { PrismaModule } from '@bbv/nestjs-prisma';
-import { AuthModule } from '@bbv/nestjs-auth';
+import { AuthModule, JwtAuthGuard } from '@bbv/nestjs-auth';
 import { OtpModule } from '@bbv/nestjs-otp';
 import { StorageModule } from '@bbv/nestjs-storage';
 import { NotificationModule, AuthNotificationModule } from '@bbv/nestjs-notifications';
@@ -164,6 +165,12 @@ import * as path from 'path';
 
     ItemsModule,
   ],
+  providers: [
+    {
+      provide: APP_GUARD,
+      useClass: JwtAuthGuard,
+    },
+  ],
   controllers: [AppController],
 })
 export class AppModule {}

apps/demo/test/app.e2e-spec.ts

@@ -255,15 +255,11 @@ describe('Demo App (e2e)', () => {
       itemId = res.body.data.id;
     });
 
-    it('POST /items without auth should still create (no global guard on items)', async () => {
-      const res = await request(httpServer)
+    it('POST /items without auth should be rejected', async () => {
+      await request(httpServer)
         .post('/items')
         .send({ name: 'No Auth Item' })
-        .expect(201);
-
-      expect(res.body.success).toBe(true);
-      expect(res.body.data.name).toBe('No Auth Item');
-      expect(res.body.data.createdBy).toBeNull();
+        .expect(401);
     });
 
     it('GET /items/:id should return single item (public)', async () => {
@@ -309,10 +305,8 @@ describe('Demo App (e2e)', () => {
       expect(res.body.data.count).toBeDefined();
     });
 
-    it('GET /notifications without auth returns empty (no global guard)', async () => {
-      const res = await request(httpServer).get('/notifications').expect(200);
-
-      expect(res.body.success).toBe(true);
+    it('GET /notifications without auth should be rejected', async () => {
+      await request(httpServer).get('/notifications').expect(401);
     });
   });
 
@@ -329,22 +323,12 @@ describe('Demo App (e2e)', () => {
     });
 
     it('PUT /notification-preferences should upsert preference (authenticated)', async () => {
-      // The preference controller reads userId from req.user which is set
-      // by the JWT strategy. Without the global APP_GUARD, userId may be
-      // undefined for unauthenticated requests, causing a Prisma error.
-      // With a valid token, it should work if the controller properly
-      // extracts the user ID.
       const res = await request(httpServer)
         .put('/notification-preferences')
         .set('Authorization', `Bearer ${accessToken}`)
         .send({ channel: 'email', type: 'marketing', enabled: false });
 
-      // This endpoint reads userId from req.user which requires the
-      // JwtAuthGuard or a global guard to populate. Since the demo app
-      // doesn't apply a global guard to this controller, userId may be
-      // undefined even with a valid bearer token, causing a 500.
-      // We accept either 200 (working) or 500 (known limitation).
-      expect([200, 500]).toContain(res.status);
+      expect(res.status).toBe(200);
     });
   });
 

packages/nestjs-notifications/src/notification.module.spec.ts

@@ -14,6 +14,9 @@ jest.mock('./channels/push/providers/firebase.provider', () => ({
     .fn()
     .mockImplementation(() => ({ send: jest.fn() })),
 }));
+jest.mock('bullmq', () => ({
+  Queue: jest.fn().mockImplementation(() => ({})),
+}));
 jest.mock('@nestjs/bullmq', () => ({
   BullModule: {
     registerQueue: jest.fn().mockReturnValue({
@@ -25,6 +28,7 @@ jest.mock('@nestjs/bullmq', () => ({
   InjectQueue: () => () => {},
   Processor: () => () => {},
   WorkerHost: class WorkerHost {},
+  getQueueToken: (name: string) => `BullQueue_${name}`,
 }));
 
 import { NotificationModule } from './notification.module';
@@ -314,6 +318,9 @@ describe('NotificationModule', () => {
       expect(providerTokens).toContain(EMAIL_PROVIDER);
       expect(providerTokens).toContain(SMS_PROVIDER);
       expect(providerTokens).toContain(PUSH_PROVIDER);
+      expect(providerTokens).toContain('BullQueue_notifications-email');
+      expect(providerTokens).toContain('BullQueue_notifications-sms');
+      expect(providerTokens).toContain('BullQueue_notifications-push');
 
       expect(result.controllers).toContain(InAppController);
       expect(result.controllers).toContain(DeviceTokenController);

packages/nestjs-notifications/src/notification.module.ts

@@ -1,5 +1,6 @@
 import { DynamicModule, Module, Provider, Type } from '@nestjs/common';
-import { BullModule } from '@nestjs/bullmq';
+import { BullModule, getQueueToken } from '@nestjs/bullmq';
+import { Queue } from 'bullmq';
 import {
   NOTIFICATION_MODULE_OPTIONS,
   EMAIL_PROVIDER,
@@ -203,6 +204,58 @@ export class NotificationModule {
         },
         inject: [NOTIFICATION_MODULE_OPTIONS],
       },
+      // Conditional BullMQ queue providers — creates Queue instances only
+      // when the channel is enabled and Redis config is present.
+      // We avoid BullModule.registerQueueAsync here to prevent @Processor
+      // workers from being created for disabled channels.
+      {
+        provide: getQueueToken('notifications-email'),
+        useFactory: (options: NotificationModuleOptions) => {
+          if (!options.channels.email?.enabled || !options.queue?.redis) {
+            return null;
+          }
+          return new Queue('notifications-email', {
+            connection: {
+              host: options.queue.redis.host,
+              port: options.queue.redis.port ?? 6379,
+              password: options.queue.redis.password,
+            },
+          });
+        },
+        inject: [NOTIFICATION_MODULE_OPTIONS],
+      },
+      {
+        provide: getQueueToken('notifications-sms'),
+        useFactory: (options: NotificationModuleOptions) => {
+          if (!options.channels.sms?.enabled || !options.queue?.redis) {
+            return null;
+          }
+          return new Queue('notifications-sms', {
+            connection: {
+              host: options.queue.redis.host,
+              port: options.queue.redis.port ?? 6379,
+              password: options.queue.redis.password,
+            },
+          });
+        },
+        inject: [NOTIFICATION_MODULE_OPTIONS],
+      },
+      {
+        provide: getQueueToken('notifications-push'),
+        useFactory: (options: NotificationModuleOptions) => {
+          if (!options.channels.push?.enabled || !options.queue?.redis) {
+            return null;
+          }
+          return new Queue('notifications-push', {
+            connection: {
+              host: options.queue.redis.host,
+              port: options.queue.redis.port ?? 6379,
+              password: options.queue.redis.password,
+            },
+          });
+        },
+        inject: [NOTIFICATION_MODULE_OPTIONS],
+      },
     ];
 
     const controllers: Type[] = [InAppController, DeviceTokenController, PreferenceController];