Repository navigation
Preserve event error code - #1151
Merged
GaryWilber merged 2 commits intoOct 7, 2026
Merged
Conversation
EventDispatcher::Flush created the JS error for EVENT_ERROR from the message text only, so the librdkafka error code was lost. LibrdKafkaError then fell back to code -1 (ERR_UNKNOWN) for every event.error, e.g. ERR__ALL_BROKERS_DOWN (-187) and ERR__TRANSPORT (-195). Keep event.err() and event.fatal() in event_t and set code and isFatal on the error object. lib/error.js already prefers a numeric e.code, so no JS change is needed. Adds a test using a minimal fake broker: after librdkafka has learned a real broker and it goes away, event.error must carry ERR__ALL_BROKERS_DOWN.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
event.error loses the numeric librdkafka error code (always -1)
EventDispatcher::Flushbuilds the JS error forEVENT_ERRORfrom the message text only, soLibrdKafkaErrorfalls back tocode = -1. A realERR__ALL_BROKERS_DOWN(-187) orERR__TRANSPORT(-195) arrives ascode: -1, so code-based restart logic never matches.Fix (small): keep
event.err()/event.fatal()inevent_tand setcodeandisFatalon the error object.lib/error.jsalready prefers a numerice.code.