fix(editor): fall back to the queue for good once a publish fails

Author: dnlblasco

app/Services/RpcBridge.php

@@ -43,8 +43,15 @@ public function call(Server $server, RpcAction $action, array $payload = []): ar
                 RpcRequested::dispatch($server, $requestId, $action, $payload);
             } catch (Throwable $failure) {
                 // The channel is the fast path, not the only one. Queue the
-                // request so the plugin still finds it on its next poll.
-                Log::warning('Could not publish an RPC request, queueing it', ['reason' => $failure->getMessage()]);
+                // request so the plugin still finds it on its next poll, and
+                // stop preferring a publish that just failed: every further
+                // attempt would pay the same timeout before falling back.
+                Log::warning('Could not publish an RPC request, falling back to the queue', [
+                    'server' => $server->uuid,
+                    'reason' => $failure->getMessage(),
+                ]);
+
+                $server->update(['uses_polling' => true]);
                 $this->enqueue($server, $requestId, $action, $payload);
             }
         }

tests/Feature/BroadcastFailureTest.php

@@ -84,6 +84,16 @@ public function test_a_request_that_cannot_be_published_is_queued_for_the_next_p
         $this->assertCount(1, $bridge->collectPending($server));
     }
 
+    public function test_stops_preferring_a_channel_that_could_not_be_published_to(): void
+    {
+        config(['editor.rpc.timeout' => 0.2, 'editor.rpc.poll_interval_ms' => 20]);
+        $server = Server::factory()->onChannel()->create();
+
+        rescue(fn () => app(RpcBridge::class)->call($server, RpcAction::MenuList));
+
+        $this->assertTrue($server->refresh()->uses_polling);
+    }
+
     private function readySession(): EditorSession
     {
         return EditorSession::factory()