Repository navigation
Commit 409853c
Fix/review 2026 10 28 (#3674)
* Fix: Web Console: Close the temporary WebView2 controller if deleting the browsing data fails (C1)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Chore: Feature review conventions: Context menu DataContext via BindingProxy in XAML (C3)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Chore: SNMP / Server profiles dialog: Remove nested BindingProxy (C6)
The top-level BindingProxy (added for the context menus) has the same key
and the same view model, the nested copies are no longer needed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Chore: Firewall: Outdated comment of ContextMenu_Opened (C7)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix: Port Scanner: Profile tooltip shows the ports to scan (F1)
The tooltip of a profile showed its own saved ports: nothing or old ports if
the ports are inherited from the group, and old names of renamed port
profiles. It now shows the ports the scan uses (own ports, otherwise the
ports of the group, port profiles with their current name).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Chore: Changelog: Link the entries of #3667
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix: Port Scanner: Scan options compare by value (F2)
The options contained the ping buffer (byte[]), records compare arrays by
reference: two options were never equal and every settings change rebuilt
the options of every Port Scanner tab without results (allocating the buffer
and re-evaluating the bindings). The options hold the buffer size, the
scanner creates the buffer once.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix: Profiles: PTR check of DNS Lookup accepts the same addresses as the lookup (F3)
The DNS Lookup looks up every host IPAddress.TryParse accepts with PTR (also
shortened IPv4 forms like "127.1"), the profile dialog only accepted the
full form: a profile with "127.1" and PTR couldn't be saved. The automatic
record type (PTR vs A) keeps the strict check.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Chore: Ping Monitor / IP Scanner / Port Scanner: Shared PingInfo from a successful reply
PingProbe (IP Scanner, Port Scanner) and Ping (Ping Monitor) created the
PingInfo of a successful reply the same way (TTL only for IPv4).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Chore: IP Scanner / Port Scanner / Ping Monitor / Traceroute: Shared limit of the ping buffer
The same limit (1 to 65500 bytes) was written in four view models.
GlobalStaticConfiguration.LimitICMPBuffer is used instead.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Chore: IP Scanner / Ping Monitor / Traceroute: Buffer size instead of the buffer in the options
Like the Port Scanner (F2): the options hold the buffer size, the scanner /
ping / traceroute creates the buffer once. IPScannerOptions is a record and
compared arrays by reference.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>1 parent 4c77eb5 commit 409853c
23 files changed
Lines changed: 149 additions & 84 deletions
File tree
- .claude/skills/feature-review/references
- Source
- NETworkManager.Converters
- NETworkManager.Models/Network
- NETworkManager.Settings
- NETworkManager
- ViewModels
- Views
- Website/docs/changelog
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
87 | | - | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
88 | 100 | | |
89 | 101 | | |
90 | 102 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
31 | 34 | | |
32 | 35 | | |
33 | 36 | | |
| |||
211 | 214 | | |
212 | 215 | | |
213 | 216 | | |
214 | | - | |
| 217 | + | |
215 | 218 | | |
216 | 219 | | |
217 | 220 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
| 30 | + | |
| 31 | + | |
31 | 32 | | |
32 | | - | |
| 33 | + | |
33 | 34 | | |
34 | 35 | | |
35 | 36 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | 4 | | |
6 | 5 | | |
7 | 6 | | |
| |||
26 | 25 | | |
27 | 26 | | |
28 | 27 | | |
29 | | - | |
| 28 | + | |
30 | 29 | | |
31 | | - | |
| 30 | + | |
32 | 31 | | |
33 | 32 | | |
34 | 33 | | |
| |||
123 | 122 | | |
124 | 123 | | |
125 | 124 | | |
| 125 | + | |
| 126 | + | |
126 | 127 | | |
127 | 128 | | |
128 | 129 | | |
| |||
139 | 140 | | |
140 | 141 | | |
141 | 142 | | |
142 | | - | |
| 143 | + | |
143 | 144 | | |
144 | 145 | | |
145 | 146 | | |
| |||
152 | 153 | | |
153 | 154 | | |
154 | 155 | | |
155 | | - | |
156 | | - | |
157 | | - | |
158 | | - | |
159 | | - | |
160 | | - | |
161 | | - | |
162 | | - | |
163 | | - | |
| 156 | + | |
| 157 | + | |
164 | 158 | | |
165 | 159 | | |
166 | 160 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
122 | 122 | | |
123 | 123 | | |
124 | 124 | | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
125 | 141 | | |
126 | 142 | | |
127 | 143 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | 4 | | |
6 | 5 | | |
7 | 6 | | |
| |||
43 | 42 | | |
44 | 43 | | |
45 | 44 | | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
| 45 | + | |
66 | 46 | | |
67 | 47 | | |
68 | 48 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| 22 | + | |
22 | 23 | | |
23 | 24 | | |
24 | 25 | | |
| |||
69 | 70 | | |
70 | 71 | | |
71 | 72 | | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
72 | 76 | | |
73 | 77 | | |
74 | 78 | | |
| |||
394 | 398 | | |
395 | 399 | | |
396 | 400 | | |
397 | | - | |
| 401 | + | |
398 | 402 | | |
399 | 403 | | |
400 | 404 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
| 36 | + | |
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
| 52 | + | |
| 53 | + | |
53 | 54 | | |
54 | | - | |
| 55 | + | |
55 | 56 | | |
56 | 57 | | |
57 | 58 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
20 | 23 | | |
21 | 24 | | |
22 | 25 | | |
23 | 26 | | |
24 | 27 | | |
25 | 28 | | |
26 | 29 | | |
| 30 | + | |
27 | 31 | | |
28 | 32 | | |
29 | 33 | | |
| |||
55 | 59 | | |
56 | 60 | | |
57 | 61 | | |
58 | | - | |
| 62 | + | |
59 | 63 | | |
60 | 64 | | |
61 | 65 | | |
| |||
0 commit comments