Repository navigation
Commit 51fedb0
Feature: WiFi review & improvements (#3695)
* Fix: WiFi: Crash when switching the tool without access to the WiFi adapter (B1)
The auto refresh timer is only created if the WiFi API is available and
the access is allowed. OnViewHide / OnViewVisible called it anyway, so
switching from WiFi to another tool threw a NullReferenceException when
the location access was denied. Regression of #3685 (not released).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix: WiFi: Crash of the auto refresh without a WiFi adapter (B2)
The auto refresh and F5 scanned the selected adapter also if no adapter
was found: ScanAsync(null) threw a NullReferenceException, which ended
the application when it came from the auto refresh timer (async void).
Both require a selected adapter now.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix: WiFi: Adapters could not be reloaded with auto refresh enabled (B3)
ReloadAdapter_CanExecute was false while the auto refresh was enabled.
Without an adapter the auto refresh toggle is hidden, so the Refresh
button below "No WiFi adapters found" stayed disabled.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Refactor: WiFi: One connect method for PSK / EAP and WPS (R1)
The connect callbacks of the dialog repeated the status message, the
result message, the hide timer and the rescan. Both use ConnectAsync
with the actual connect call as delegate now. No behavior change.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix: WiFi: Crash and blocked scan if connecting fails with an error (B4)
The connect callbacks run as async void: an exception of
WiFiAdapter.ConnectAsync ended the application and IsConnecting stayed
set, which blocked the refresh and the auto refresh. ConnectAsync catches
the error now, shows it in the connection status and resets IsConnecting
in finally. Disconnect (async void) catches its error the same way.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix: WiFi: Connect / Disconnect available while connecting or without a network (B11)
Both commands had no CanExecute: a second connection could be started
while one was made, and Connect read SelectedNetwork without a check
(null after the networks were scanned again while the menu was open).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix: WiFi: Use credentials ignored when connecting with EAP (B5)
UseCredentials of the connect dialog was never read: the (empty) username
and password were always sent. They are only set if Use credentials is
enabled now; otherwise an empty credential is passed like for open
networks.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix: WiFi: WPS button of the connect dialog never shown (B6)
CheckWpsAsync lost its caller when the dialog was migrated to a child
window (#3271), so IsWpsAvailable stayed false. It is called when the
dialog is loaded again. An error of the check is logged and leaves WPS
unavailable instead of keeping "Checking WPS..." visible.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix: WiFi: Focus of the connect dialog (B7)
Both branches focused the pre-shared key box (lost in the migration to a
child window, #3271), which is hidden for a hidden network (SSID) and for
EAP (username). The first visible input is focused again.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix: WiFi: Connect mode of WPA3 Enterprise and OWE networks (B8)
GetConnectMode only knew WPA / WPA2 Enterprise: WPA3 Enterprise (also
192-bit) got the pre-shared key dialog, and OWE (Enhanced Open, encrypted
without a password) too, with Connect disabled until a key was typed.
GetConnectMode has an overload for the authentication / encryption type
now, with unit tests.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix: WiFi: Wide channels drawn around the primary channel (B19)
ChannelCenterFrequencyInKilohertz of WiFiAvailableNetwork is the
frequency of the primary 20 MHz channel, where the beacons are sent. The
channel chart centered each network on it, so every 40 / 80 / 160 MHz
network was drawn shifted (80 MHz on channel 36 over 28 - 44 instead of
36 - 48).
WlanApi returns the center of the whole channel with the width now, from
the same information elements: HT secondary channel offset, VHT CCFS0 /
CCFS1 (new and deprecated 160 MHz encoding), HE 6 GHz Operation CCFS0 /
CCFS1. VHT / HE are parsed after the element loop, so the HT fallback no
longer depends on the order of the elements. The chart uses the new
ChannelBandwidthCenterFrequencyInGigahertz; the Channel / Frequency
columns stay the primary channel. Unit tests for the parsing.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix: WiFi: 320 MHz channels shown as 160 MHz (B20)
The EHT Operation element (802.11be, extension id 106) was not parsed,
so 320 MHz channels got the 160 MHz of the HE element. Its channel width
and center (CCFS0 / CCFS1) are read now, with unit tests.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Feature: WiFi: Mark estimated channel widths (C7)
If the channel width can't be read from the BSS list, it is estimated
from the band and the PHY kind, but it looked like a measured value.
WiFiNetworkInfo.IsChannelBandwidthEstimated marks it; the grid, the copy
menu and the chart tooltip show "~80 MHz", the grid cell has a tooltip
with the reason. The estimate for 2.4 GHz is 20 MHz (also for 802.11n,
40 MHz is rarely used on 2.4 GHz).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix: WiFi: Wrong 5 GHz channel labels above channel 144 (B9)
BuildChannelSet(100, 165, 4) produced 148, 152 ... 164, but the UNII-3
channels are 149, 153 ... 165.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix: WiFi: Channels outside the known 5 / 6 GHz ranges shown as -1 (B16)
The 5 GHz range ended at 5825 MHz (channel 165): channels 169 - 177
(UNII-4) and 32 got the radio Unknown and channel -1, so they ignored
the band filter and were not drawn. 6 GHz channel 2 (5935 MHz, below
channel 1) got -1 as well and was drawn outside the axis.
The ranges cover 5160 - 5885 MHz and channel 2 now, the 5 / 6 GHz chart
axes include them. GetChannelFromChannelFrequency and
GetWiFiRadioFromChannelFrequency are public for unit tests.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix: WiFi: Sorting by the signal icon and Encryption did nothing (B10)
The SortMemberPath of the icon column pointed to a property that doesn't
exist on WiFiNetworkInfo (ChannelCenterFrequencyInKilohertz), the one of
Encryption missed SecuritySettings. The icon column sorts by the signal
bars it shows now.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix: WiFi: Adapter could be changed while scanning (B13)
Selecting another adapter during a scan started a second scan; the one
that finished last won, possibly the one of the previous adapter. The
adapter selection is disabled while scanning or connecting
(CanChangeAdapter).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix: WiFi: Failed refresh removed all networks (B14)
A failed scan cleared the networks and charts until the next scan, also
for a refresh (manual, auto refresh, the rescan after connecting, which
can fail while the adapter is busy). A refresh keeps the networks of the
last scan now and only shows the error, like a failed repeated scan of
the IP Scanner. A failed first scan of an adapter still clears them.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix: WiFi: Hidden network in the disconnect message and the search (B17)
The disconnect message used the empty SSID of a hidden network, and the
search compared with the empty SSID instead of "Hidden Network" shown in
the grid. GetDisplaySsid is used for both and for the chart series and
legend (same logic before).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix: WiFi: Adapter icon kept the state of the first load (B18)
The up / down icon of the adapter selection was bound to
NetworkInterfaceInfo.IsOperational, read once when the adapters were
loaded, so it still showed "up" after a disconnect. WiFiAdapterInfo has a
notifying IsOperational now, updated after each scan from the
operational status of the network interfaces (cheap, without the
PowerShell query of GetNetworkInterfaces).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix: WiFi: Refresh behind an open dialog (C2)
F5, the adapter reload and the auto refresh didn't check for an open
dialog (like the Connections or the IP Scanner do), so the list was
replaced behind the connect or export dialog. They wait until it is
closed now.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Feature: WiFi: Check the access to the WiFi adapter again (C1, M2)
The access was only requested in the constructor: after it was allowed
in the Windows settings, the application had to be restarted. The
constructor always sets up the list and the timers now; the adapters
are loaded (and the auto refresh enabled) once the access is allowed,
which is checked again by a Refresh button next to Open settings and
when the view is shown again.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Feature: WiFi: BSSID in the default MAC address format (C6)
The BSSID was shown in the format of the WinRT API (lowercase), the IP
Scanner and the other tools use MACAddressHelper.GetDefaultFormat
(uppercase). WiFiNetworkInfo.Bssid has the formatted value; grid, copy,
search, chart legend / tooltip and the export use it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Feature: WiFi: Keep the networks while the adapters are reloaded (C8)
Reloading the adapters selects a new instance of the same adapter, which
started a scan with the full loading indicator in place of the grid. A
scan of the same adapter is a background refresh now (like the auto
refresh), only a different adapter shows the loading indicator.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix: WiFi: Untranslated "Unknown" for security and PHY kind (O2)
GetHumanReadableNetworkAuthenticationType / GetHumanReadablePhyKind
returned the hard-coded English text "Unknown". The model has no access
to the strings, so the placeholder for no value is used, like for an
unknown vendor and the authentication type None. The technical terms
(Open, WEP, WPA2 Personal (PSK), 802.11ax) stay.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Refactor: WiFi: One field list for the CSV, XML and JSON export (R3)
The CSV header, the CSV row, the XML elements and the JSON object each
listed the same 12 values. One list of fields (name + value) drives all
three formats now, like the export of the IP Scanner. Same columns,
order and values per format (CSV / JSON text in the current culture,
XML values as before). No unit test: WiFiAvailableNetwork (WinRT) can't
be created outside of a scan.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Feature: WiFi: Export channel, channel width, vendor, connected, security (M1)
The export lacked the values the grid shows next to the ones of the
WinRT API: IsConnected, Security (human-readable authentication),
Channel, ChannelWidth, ChannelWidthEstimated and Vendor. They are
appended at the end, the existing columns keep their position.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix: WiFi: SSID with a comma broke the CSV export (O1)
The CSV values were not quoted, so an SSID with a comma or a quote
shifted the columns of its row. The text values (SSID, security,
vendor) are quoted with CsvHelper.QuoteString, like in the other
exports.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Feature: WiFi: Export the shown networks in grid order (C5)
Export all wrote every scanned network (also the bands hidden by the
filter and the networks hidden by the search) in scan order, selected
networks in click order, on the UI thread. Like the IP Scanner, the
filtered view is exported in its order (selected ones too) and the
file is written in Task.Run.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix: WiFi: Connected network via the WiFi API instead of netsh (P1, B12, B15)
Every scan ran "netsh wlan show interfaces" in a new PowerShell
instance synchronously on the UI thread (after await ScanAsync), and
parsed its (localized) text: the window froze briefly every scan, an
exception of PowerShell ended the whole scan (B15), and with several
adapters the lines of the next adapter were read if the scanned one was
not connected (B12).
WlanApi.GetConnectedBssid reads the BSSID with WlanQueryInterface
(wlan_intf_opcode_current_connection); null if not connected or on an
error. Everything after adapter.ScanAsync (native calls, OUI lookups,
now synchronous) runs in Task.Run.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Refactor: WiFi: Remove dead code (R4)
WiFiNetworkScanInfo.NetworkAdapterId was set but never read, the
constructors of WiFiNetworkInfo / WiFiNetworkScanInfo were empty. The
file of WiFiNetworkScanInfo had a typo in its name (WiFiNetworkScannfo).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Feature: WiFi: Keep the selected network when scanning again (P2, C4)
Every scan cleared the networks and added them one by one into the
sorted view, so the selection and the position in the list were lost
every 30 s with the auto refresh. Like the Firewall, the networks are
replaced with one notification (ObservableRangeCollection.ReplaceAll)
and the selected network is selected again by its BSSID (if it is still
shown) and scrolled into view.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Feature: WiFi: Copy the SSID / BSSID of several networks (M3)
With several networks selected, the context menu only had Export...
Like the IP Scanner, Copy... > SSID / BSSID copies the value of all
selected networks, one per line in the grid order, without duplicates
(hidden networks have no SSID).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Feature: WiFi: Changes since the last scan (M4)
Like the IP Scanner (Since last scan), each scan is compared with the
previous scan of the same adapter by BSSID (WiFiScanComparer, with unit
tests): New, Gone and Changed (channel, channel width if both were read
from the beacon, or security; the signal is not a change). Gone networks
stay as faded rows until the next scan (not drawn in the charts, Connect
disabled). A Since last scan column (icon + text, the tooltip of a
changed network shows its previous values) and the counters in the
header are shown once a scan is compared; the change is also in the
search and the export (Change, last column). Only in memory, another
adapter starts over.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Docs: WiFi: Toolbar, columns, connect, export, changes and channels (O3, D1-D7)
The WiFi documentation was behind the tool: toolbar (adapter, last scan,
auto refresh, bands, search), column table incl. the estimated channel
width, changes since the last scan, context menu in the order of the UI
with the multi-selection, the connect dialog, the export (formats,
columns, filtered networks in grid order), and the Channels tab (center
of the whole channel, legend, signal-quality bands, what the filter
doesn't apply to). The location access no longer needs a restart.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Chore: Feature review skill: Write tests with every fix and feature
The review checks which logic of a feature has no unit tests (area 10,
findings T1, ...), and fixes / features get unit tests in the same commit
where possible, with testable logic moved into small public static
methods in NETworkManager.Models (like IPScannerScanComparer).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Docs: Changelog: Tool sections in the order of the application list
The sections of each block of next-release.md were in no particular
order (e.g. Whois before IP Scanner). The tool sections follow the order
of the applications (ApplicationName) now, the cross-cutting sections
(Run command, Settings, Profiles, History, Input validation) stay in
front of them. The two WiFi sections of the bug fixes are merged. No
entry changed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix: WiFi: Error reading the adapter states failed the scan (B22)
UpdateAdapterStates (icon of the adapter selection, B18) runs after a
successful scan inside its try block: an exception (e.g. a
NetworkInformationException) showed the scan as failed. It is optional,
so the error is logged and the previous states are kept. Duplicate
interface ids no longer throw (TryAdd instead of ToDictionary).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix: WiFi: Header kept the last scan of the previous adapter (B21)
If the first scan of another adapter failed, the networks were cleared,
but the header still showed the time of the last scan and the changes
(New / Gone counters) of the previous adapter. They are reset as well.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Feature: WiFi: Notification for changes of the auto refresh (M5)
Like the IP Scanner after a repeated scan: when an automatic refresh
found changes since the previous scan (New / Gone / Changed), a
notification shows them (up to three networks, otherwise the counters),
with the status icon from NotificationStatusHelper. A click opens WiFi.
New WiFi settings page (SettingsName.WiFi) with the settings of the IP
Scanner and the same defaults: WiFi_ShowNotificationPopup (on),
WiFi_NotificationSound (off), WiFi_NotificationCloseTime (10 s).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix: WiFi: Auto refresh during a reload of the adapters (B23)
Since the adapters can be reloaded with the auto refresh enabled (B3),
the timer could scan while they were reloaded; selecting the reloaded
adapter then started a second scan of the same adapter: two overlapping
WiFiAdapter.ScanAsync, the flags reset by the first one and the
comparison done twice (counters lost). The auto refresh waits while the
adapters are loading.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix: WiFi: Removed adapter kept after reloading the adapters (B24)
If a reload found no adapter (e.g. a USB adapter was unplugged), the
removed adapter stayed selected and the auto refresh (its toggle hidden
with the adapters) scanned it at every interval. It is deselected now.
If loading the adapters failed, Adapters.Clear() didn't update the view
(a List without notification), so the previous adapters were still
shown; an empty list is set instead.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix: WiFi: Center of 6 GHz channel 2 (B25)
WlanApi.ChannelToFrequency converted every 6 GHz channel with
5950 + ch * 5, also channel 2 (5935 MHz, below channel 1), which
GetChannelFromChannelFrequency and the chart handle as a special case:
a network on channel 2 was drawn at 5960 MHz. Unit test.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix: WiFi: Center of 6 GHz 80+80 MHz channels (B26)
For the 6 GHz Operation Information with a width of 160 / 80+80 MHz,
CCFS1 was always used as the center. For 80+80 MHz (segments more than 8
channels apart) it is the center of the second segment, so the network
was drawn far from its primary channel. Like the VHT element, 80+80 MHz
is centered on the primary segment now. Unit test.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix: WiFi: No network name in the message of a failed disconnect (B27)
If disconnecting failed and no network was marked as connected (e.g. a
stale state), the message was formatted with an empty name ("Could not
disconnect from (...)!"). The selected network is used then; the
command is only available with a selected network (B11).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix: WiFi: Access check blocked the UI on every switch to WiFi (P3)
Since C1, the access to the WiFi adapter is checked again on every
switch to WiFi while it is denied, with RequestAccessAsync().GetAwaiter()
.GetResult() on the UI thread. CheckAccessAsync awaits it now (and runs
only once at a time); the constructor keeps the synchronous check (the
access decides what is shown), without a deadlock as the awaited task
doesn't continue on the UI thread.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Refactor: WiFi: One WLAN client handle per scan (R5)
GetConnectedBssid and GetBssChannels each opened and closed their own
client handle, with the same open / close code twice. GetBssInfo reads
both with one handle; an error reading the connected network still
doesn't stop reading the BSS list. No behavior change.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix: WiFi: Reloading the adapters showed the loading indicator (B28)
C8 decided "same adapter" by the previous value of SelectedAdapter.
Replacing the adapters (new instances) makes the combo box clear its
selection first (null pushed through the TwoWay binding), so the
reloaded adapter never counted as the same one: the loading indicator
replaced the networks and a failed scan cleared them. It is compared
with the adapter of the shown networks now (_previousScanAdapterId),
which is reset when the networks are cleared after a failed first scan.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix: WiFi: WEP with open authentication treated as unsecured (B29)
GetConnectMode returned Open for the authentication type Open80211
regardless of the encryption, so a WEP network with open-system
authentication (Open80211 + WEP) got no key field and the connect failed.
Open is decided by the encryption now (None, or OWE). The signal icon
showed no lock for the same reason (Open80211): it checks the encryption
type None now. Unit tests.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix: WiFi: Adapter could be changed while the adapters were reloaded (B30)
CanChangeAdapter (B13) didn't include IsAdaptersLoading: during the
reload (at least 2.5 s) another adapter could be selected, which started
a scan, and the reload then selected the previous adapter again with a
second, overlapping scan. The adapter selection is disabled while the
adapters are reloaded.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix: WiFi: Connect / Disconnect during a scan started a second scan (B31)
Connect and Disconnect scan the networks again afterwards, but their
CanExecute only checked IsConnecting: during an (auto) refresh the
second scan overlapped the running one (WiFiAdapter.ScanAsync busy, the
flags reset by the first one, the comparison done twice). They are
disabled while a scan is running.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix: WiFi: 6 GHz network across the chart split cut off (B32)
6 GHz networks were assigned to the lower or upper chart by their center
only. A 320 MHz channel around channel 127 (95 - 159) went to the upper
chart (axis from 126), its left half was cut off and the lower chart
didn't show it. Networks are assigned by the channels they cover now; one
that crosses the split is drawn in both charts. Documented.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix: WiFi: Networks and scan time from different network reports (B33)
CreateScanInfo read adapter.NetworkReport twice (networks, timestamp);
every access returns the current report, so a background scan in
between could show the time of another report than the networks. The
report is read once.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Refactor: WiFi: One mapping from channel to frequency (R6)
WlanApi.ChannelToFrequency had its own copy of the band rules
(2.4 GHz channel 14, 6 GHz channel 2, band boundaries), which drifted
from WiFi.GetChannelFromChannelFrequency (B25). The inverse mapping is
WiFi.GetFrequencyFromChannel now, next to the forward one, and a test
checks every channel of each band back and forth. The chart position
(FrequencyToChannelAxis) stays separate: it is an axis position, not a
channel number (6 GHz channel 2 at -3). No behavior change.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Refactor: WiFi: One connect call and one timeout handling (R7)
The connect callback called WiFi.ConnectAsync in two branches with the
same arguments (with / without the SSID of a hidden network), although
ConnectAsync already decides by the SSID. ConnectAsync and
ConnectWpsAsync repeated the disconnect after a timeout, which is one
helper now. No behavior change.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Refactor: WiFi: One place for the shown SSID (R8)
The SSID as shown ("Hidden Network" for a hidden network) was built in
the view model (grid search, chart legend, notification, disconnect
message) and again in the chart tooltip. Both use
WiFiNetworkToSsidStringConverter.GetSsid now, so they can't differ. No
behavior change.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Refactor: WiFi: Shared styles and one class for the channel charts (R2)
The Channels tab repeated the same chart attributes and the same legend
(panel + item template) for each of the 4 charts, and the view model had
5 properties per chart (series, legend, X / Y axes, sections). The chart
attributes and the legend are two styles (WiFiChannelChart,
WiFiChannelLegend) now; the grid layout of the tabs is unchanged (no
template around a chart, so the row heights stay the same). Each chart
is a WiFiChannelChart (axes and sections fixed, series and legend
replaced on every scan), which also shortens building and clearing them
in ScanAsync. No behavior change - to be checked visually on Windows.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Refactor: WiFi: Position on the channel charts in the model, with tests (T1)
The mapping from a frequency to the X axis of the channel charts (5 GHz gap, 6 GHz split, axis labels) moves from
private methods of the view model to WiFiChannelAxis, so it can be tested (B9, B19, B32 had no tests). No behaviour
change.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix: WiFi: 6 GHz network across the chart split in two colors (B34)
A network drawn in both 6 GHz charts (e.g. 320 MHz around channel 127, B32) got its color from its position in each
chart, so the two halves and their legend entries could have different colors. The two 6 GHz charts count the colors
together now.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix: WiFi: Grid jumped to the selected network on a selection change (B35)
The selected network was scrolled into view on every change of the selection (P2), also when the user changed it,
e.g. Ctrl+click on the first selected row while scrolled away: the grid jumped to the next selected row. It is only
scrolled into view after the networks were replaced by a scan now.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Chore: Feature review skill: Own table for missing tests in the report
Missing tests (area 10, T1, ...) were reported under "Other" and could get lost. They get their own table with the
bugs they would have caught and the proposed move to NETworkManager.Models.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Fix: WiFi: Connect / Disconnect during a reload of the adapters started a second scan (B36)
Connect... / Disconnect were not blocked while the adapters were reloaded (the networks stay visible when the same
adapter is reloaded). Disconnect scanned the old adapter while the reload scanned the reloaded one: two scans at the
same time, and the changes since the last scan could be counted twice or lost. Both wait until the reload is finished
now, like the other actions. Changelog entry of B31 extended.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Docs: WiFi: PR number in the changelog (#3695)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Refactor: WiFi: Shared check for an open dialog (DialogHelper.IsAnyDialogOpen)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Refactor: Use DialogHelper.IsAnyDialogOpen in all view models
Replaces the copied check (main window, MahApps dialog, child window) in 21 view models; no behaviour change.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Chore: Feature review skill: DialogHelper.IsAnyDialogOpen in the conventions
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>1 parent dedab5c commit 51fedb0
63 files changed
Lines changed: 2800 additions & 1003 deletions
File tree
- .claude/skills/feature-review
- references
- Source
- NETworkManager.Converters
- NETworkManager.Documentation
- NETworkManager.Localization/Resources
- NETworkManager.Models
- Export
- Network
- NETworkManager.Settings
- NETworkManager.Tests/Network
- NETworkManager
- Controls
- ViewModels
- Views
- Website/docs
- application
- changelog
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
104 | 104 | | |
105 | 105 | | |
106 | 106 | | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
107 | 113 | | |
108 | 114 | | |
109 | 115 | | |
| |||
184 | 190 | | |
185 | 191 | | |
186 | 192 | | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
187 | 196 | | |
188 | 197 | | |
189 | 198 | | |
| |||
220 | 229 | | |
221 | 230 | | |
222 | 231 | | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
223 | 238 | | |
224 | 239 | | |
225 | 240 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
134 | 134 | | |
135 | 135 | | |
136 | 136 | | |
| 137 | + | |
| 138 | + | |
137 | 139 | | |
138 | 140 | | |
139 | 141 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
7 | 12 | | |
8 | 13 | | |
9 | 14 | | |
10 | 15 | | |
11 | | - | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
12 | 25 | | |
13 | 26 | | |
14 | 27 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
260 | 260 | | |
261 | 261 | | |
262 | 262 | | |
| 263 | + | |
263 | 264 | | |
264 | 265 | | |
265 | 266 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5450 | 5450 | | |
5451 | 5451 | | |
5452 | 5452 | | |
| 5453 | + | |
| 5454 | + | |
| 5455 | + | |
| 5456 | + | |
| 5457 | + | |
| 5458 | + | |
| 5459 | + | |
| 5460 | + | |
| 5461 | + | |
| 5462 | + | |
| 5463 | + | |
| 5464 | + | |
| 5465 | + | |
| 5466 | + | |
| 5467 | + | |
| 5468 | + | |
| 5469 | + | |
| 5470 | + | |
5453 | 5471 | | |
0 commit comments