Repository navigation
Fix: Various improvements - #3674
Merged
Merged
Conversation
… the browsing data fails (C1) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ngProxy in XAML (C3) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The top-level BindingProxy (added for the context menus) has the same key and the same view model, the nested copies are no longer needed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The tooltip of a profile showed its own saved ports: nothing or old ports if the ports are inherited from the group, and old names of renamed port profiles. It now shows the ports the scan uses (own ports, otherwise the ports of the group, port profiles with their current name). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The options contained the ping buffer (byte[]), records compare arrays by reference: two options were never equal and every settings change rebuilt the options of every Port Scanner tab without results (allocating the buffer and re-evaluating the bindings). The options hold the buffer size, the scanner creates the buffer once. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…the lookup (F3) The DNS Lookup looks up every host IPAddress.TryParse accepts with PTR (also shortened IPv4 forms like "127.1"), the profile dialog only accepted the full form: a profile with "127.1" and PTR couldn't be saved. The automatic record type (PTR vs A) keeps the strict check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… a successful reply PingProbe (IP Scanner, Port Scanner) and Ping (Ping Monitor) created the PingInfo of a successful reply the same way (TTL only for IPv4). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…limit of the ping buffer The same limit (1 to 65500 bytes) was written in four view models. GlobalStaticConfiguration.LimitICMPBuffer is used instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… the buffer in the options Like the Port Scanner (F2): the options hold the buffer size, the scanner / ping / traceroute creates the buffer once. IPScannerOptions is a record and compared arrays by reference. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See commits
Related issue
Closes #
Type of change
How has this been tested?
Screenshots
Checklist
dotnet build,dotnet test).Strings.resx(translations are done on Transifex).Source/3rdparty/are changed.Contributing
By submitting this pull request, I confirm that: