Skip to content

Fix: Include AirspacePanel as control with custom fixes - #3681

Merged
mergify[bot] merged 3 commits into
mainfrom
fix/airspace-panel-dpi
Oct 30, 2026
Merged

mergify[bot] merged 3 commits into
mainfrom
fix/airspace-panel-dpi

Conversation

@BornToBeRoot

Copy link
Copy Markdown
Owner

Description

Replace the nuget package with a control based on the original and a fork with some fixes.

Related issue

Closes #

Type of change

  • 🐛 Bug fix
  • ✨ New feature / improvement
  • 📖 Documentation / website
  • 🧹 Refactoring / maintenance (no functional change)

…xer in NETworkManager.Controls

The screenshot shown in place of embedded windows (Remote Desktop, PowerShell, PuTTY, TigerVNC,
Web Console) while a dialog is open was taken with the wrong size (AirspaceFixer 1.0.6 gets a
scaling factor of 1.0 for a PerMonitorV2 application) and leaked a Graphics object / device
context. 1.1.0 is unlisted on NuGet and scales the (already physical) position again.

AirspacePanel is now part of NETworkManager.Controls, based on AirspaceFixer and its fork
AirspaceFixerDotNet (both MIT, notice kept in the source, style and license file): position in
physical pixels, size scaled with the DPI of the monitor (TransformToDevice). In addition the
content is always shown again when FixAirspace is reset, nothing is swapped if the template is
missing or the content has no size, and the screenshot is frozen. The template is an implicit
style in Resources/Styles/AirspacePanelStyles.xaml. The NuGet package is removed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 29, 2026 23:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@mergify

mergify Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

BornToBeRoot and others added 2 commits October 30, 2026 00:35
… while a dialog is open

The screenshot was stretched / scaled to the panel (Image Stretch=Uniform). It is now shown in the
size of the content when it was taken, top left aligned and clipped, like a frozen frame. A new
screenshot can't be taken while the dialog is open (content hidden, dialog on top).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mergify
mergify Bot merged commit 9b82ee0 into main Oct 30, 2026
5 checks passed
@mergify
mergify Bot deleted the fix/airspace-panel-dpi branch October 30, 2026 00:10
mergify Bot pushed a commit that referenced this pull request Oct 30, 2026
skip_branch_with_pr only works for pushes after the PR exists. The first push of a branch (e.g.
Dependabot pushes and opens the PR within seconds, #3678 / #3681) is still built as branch build,
which blocks the single AppVeyor job for nothing. Other branches are only built as PR now; the
branch filter also applies to tag names, so release tags are included via a pattern.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants