Skip to content

Fix typescript type - #122

Open
Bunlong wants to merge 8 commits into
masterfrom
fix-typescript-type
Open

Fix typescript type#122
Bunlong wants to merge 8 commits into
masterfrom
fix-typescript-type

Conversation

@Bunlong

@Bunlong Bunlong commented Jan 26, 2022

Copy link
Copy Markdown
Owner

Features

  • Fix typescript type

Issues

@MichielDeMey

Copy link
Copy Markdown
Contributor

LGTM 👍
We do however need to figure out how to type the props from the render function.

<CSVReader>
{/* How to type these props? */}
{({ getRootProps, acceptedFile, ProgressBar, getRemoveFileProps, Remove }) => (
  return <>Foo</>
)}
</CSVReader>

@Bunlong

Bunlong commented Jan 27, 2022

Copy link
Copy Markdown
Owner Author

@MichielDeMey

Yes, I got it. If you have any more ideas or suggestions please kindly let us know. We very much appreciate for your contribution. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants