Skip to content
This repository was archived by the owner on Jul 27, 2025. It is now read-only.
This repository was archived by the owner on Jul 27, 2025. It is now read-only.

Suggest you rename the TimeInterval enum to something more specific to this library #19

Description

@astrohart
namespace CoinCapApi.Types
{
    public enum TimeInterval
    {
        /// <summary>
        /// 1 minute
        /// </summary>
        M1 = 1,

        /// <summary>
        /// 5 minutes
        /// </summary>
        M5 = 2,

        /// <summary>
        /// 15 minutes
        /// </summary>
        M15 = 4,

        /// <summary>
        /// 30 minutes
        /// </summary>
        M30 = 8,

        /// <summary>
        /// 1 hour
        /// </summary>
        H1 = 16,

        /// <summary>
        /// 2 hours
        /// </summary>
        H2 = 32,

        /// <summary>
        /// 6 hours
        /// </summary>
        H6 = 64,

        /// <summary>
        /// 12 hours
        /// </summary>
        H12 = 128,

        /// <summary>
        /// 1 day (24 hours)
        /// </summary>
        D1 = 256
    }
}

Listing 1. The TimeInterval enum.

@ByronAP hello. I have a suggestion. The enum shown in Listing 1 is named TimeInterval. This is pretty generic.

I suggest you rename it something such as CoinCapTimeInterval or somesuch. This way, it would not clash with any other symbols that the developer consuming this library has named TimeInterval as well.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions