Skip to content

Commit 09bc892

Browse files
committed
tests(unit): cover cached residue axes topology
1 parent f349c09 commit 09bc892

3 files changed

Lines changed: 233 additions & 6 deletions

File tree

‎tests/unit/CodeEntropy/levels/nodes/test_axes_topology.py‎

Lines changed: 84 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
from CodeEntropy.levels.nodes.axes_topology import (
88
AxesTopology,
99
BuildAxesTopologyNode,
10+
ResidueAxesTopology,
1011
UAAxesTopology,
1112
)
1213

@@ -62,10 +63,14 @@ def __init__(self, atoms):
6263

6364

6465
class FakeMolecule:
65-
"""Small molecule-like object with residues."""
66+
"""Small molecule-like object with residues and selections."""
6667

67-
def __init__(self, residues):
68+
def __init__(self, residues, select_map=None):
6869
self.residues = residues
70+
self._select_map = dict(select_map or {})
71+
72+
def select_atoms(self, selection):
73+
return self._select_map.get(selection, FakeAtomGroup([]))
6974

7075

7176
class FakeAtoms:
@@ -140,10 +145,23 @@ def test_ua_axes_topology_dataclass_preserves_arrays():
140145
np.testing.assert_allclose(topology.residue_ua_masses, np.array([13.0, 12.0, 14.0]))
141146

142147

143-
def test_axes_topology_defaults_to_empty_ua_mapping():
148+
def test_residue_axes_topology_dataclass_preserves_arrays():
149+
topology = ResidueAxesTopology(
150+
residue_heavy_indices=np.array([1, 3, 4]),
151+
residue_ua_masses=np.array([13.0, 12.0, 14.0]),
152+
has_neighbor_bonds=True,
153+
)
154+
155+
np.testing.assert_array_equal(topology.residue_heavy_indices, np.array([1, 3, 4]))
156+
np.testing.assert_allclose(topology.residue_ua_masses, np.array([13.0, 12.0, 14.0]))
157+
assert topology.has_neighbor_bonds is True
158+
159+
160+
def test_axes_topology_defaults_to_empty_mappings():
144161
topology = AxesTopology()
145162

146163
assert topology.ua == {}
164+
assert topology.residue == {}
147165

148166

149167
def test_run_writes_empty_topology_when_customised_axes_disabled():
@@ -154,9 +172,72 @@ def test_run_writes_empty_topology_when_customised_axes_disabled():
154172

155173
assert isinstance(result["axes_topology"], AxesTopology)
156174
assert result["axes_topology"].ua == {}
175+
assert result["axes_topology"].residue == {}
157176
assert shared_data["axes_topology"] is result["axes_topology"]
158177

159178

179+
def test_run_builds_residue_topology_for_residue_levels():
180+
node = BuildAxesTopologyNode()
181+
universe, molecule, heavy, hydrogen, bonded_heavy, other_residue_heavy = (
182+
_single_molecule_universe()
183+
)
184+
neighbor_query = "(resindex -1 or resindex 1) and bonded resid 0"
185+
molecule._select_map[neighbor_query] = FakeAtomGroup([bonded_heavy])
186+
shared_data = {
187+
"args": _args(customised_axes=True),
188+
"reduced_universe": universe,
189+
"levels": [["residue"]],
190+
"beads": {(0, "residue"): [np.array([1, 2, 3, 4])]},
191+
}
192+
193+
result = node.run(shared_data)
194+
195+
axes_topology = result["axes_topology"]
196+
assert axes_topology.ua == {}
197+
assert set(axes_topology.residue) == {(0, 0)}
198+
199+
residue_topology = axes_topology.residue[(0, 0)]
200+
np.testing.assert_array_equal(
201+
residue_topology.residue_heavy_indices,
202+
np.array([heavy.index, bonded_heavy.index, other_residue_heavy.index]),
203+
)
204+
np.testing.assert_allclose(
205+
residue_topology.residue_ua_masses,
206+
np.array([13.0, 12.0, 14.0]),
207+
)
208+
assert residue_topology.has_neighbor_bonds is True
209+
210+
211+
def test_add_residue_topology_skips_when_no_residue_beads():
212+
node = BuildAxesTopologyNode()
213+
_, molecule, _, _, _, _ = _single_molecule_universe()
214+
out = {}
215+
216+
node._add_residue_topology(
217+
mol=molecule,
218+
mol_id=0,
219+
beads={},
220+
out=out,
221+
)
222+
223+
assert out == {}
224+
225+
226+
def test_has_neighbor_bonds_uses_original_residue_selection():
227+
node = BuildAxesTopologyNode()
228+
query = "(resindex 0 or resindex 2) and bonded resid 1"
229+
molecule = FakeMolecule([], select_map={query: FakeAtomGroup([FakeAtom(1, 12.0)])})
230+
231+
assert node._has_neighbor_bonds(mol=molecule, local_res_i=1) is True
232+
233+
234+
def test_has_neighbor_bonds_returns_false_for_empty_selection():
235+
node = BuildAxesTopologyNode()
236+
molecule = FakeMolecule([])
237+
238+
assert node._has_neighbor_bonds(mol=molecule, local_res_i=1) is False
239+
240+
160241
def test_run_builds_ua_topology_for_united_atom_levels():
161242
node = BuildAxesTopologyNode()
162243
universe, _, heavy, hydrogen, bonded_heavy, other_residue_heavy = (

‎tests/unit/CodeEntropy/levels/nodes/test_covariance_node.py‎

Lines changed: 45 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
"""Atomic unit tests for frame-local covariance construction."""
2-
31
from __future__ import annotations
42

53
from types import SimpleNamespace
@@ -122,6 +120,9 @@ def test_run_processes_all_levels_and_writes_frame_covariance():
122120
assert ua_kwargs["customised_axes"] is True
123121
assert ua_kwargs["is_highest"] is False
124122

123+
res_kwargs = node._process_residue.call_args.kwargs
124+
assert res_kwargs["axes_topology"] is axes_topology
125+
125126

126127
def test_run_omits_forcetorque_when_combined_is_false():
127128
node = FrameCovarianceNode()
@@ -255,6 +256,7 @@ def test_process_residue_updates_outputs_and_combined_ft():
255256
group_id=7,
256257
beads={(0, "residue"): [np.array([0])]},
257258
axes_manager="axes",
259+
axes_topology=None,
258260
box=None,
259261
customised_axes=True,
260262
force_partitioning=0.5,
@@ -284,6 +286,7 @@ def test_process_residue_returns_when_no_beads_or_empty_groups():
284286
group_id=7,
285287
beads={},
286288
axes_manager=None,
289+
axes_topology=None,
287290
box=None,
288291
customised_axes=False,
289292
force_partitioning=0.5,
@@ -305,6 +308,7 @@ def test_process_residue_returns_when_no_beads_or_empty_groups():
305308
group_id=7,
306309
beads={(0, "residue"): [np.array([0])]},
307310
axes_manager=None,
311+
axes_topology=None,
308312
box=None,
309313
customised_axes=False,
310314
force_partitioning=0.5,
@@ -522,9 +526,12 @@ def test_build_residue_vectors_uses_residue_axes():
522526
node._ft.get_weighted_torques = MagicMock(return_value=np.array([0.0, 1.0, 0.0]))
523527

524528
force_vecs, torque_vecs = node._build_residue_vectors(
529+
u=FakeUniverse([mol]),
525530
mol=mol,
531+
mol_id=0,
526532
bead_groups=[FakeAtomGroup("res")],
527533
axes_manager=axes_manager,
534+
axes_topology=None,
528535
box=None,
529536
customised_axes=True,
530537
force_partitioning=0.5,
@@ -536,6 +543,34 @@ def test_build_residue_vectors_uses_residue_axes():
536543
node._get_residue_axes.assert_called_once()
537544

538545

546+
def test_get_residue_axes_customised_uses_cached_topology_when_available():
547+
node = FrameCovarianceNode()
548+
mol = FakeMolecule(n_residues=1)
549+
axes_manager = MagicMock()
550+
expected = (np.eye(3), np.eye(3) * 2.0, np.zeros(3), np.ones(3))
551+
residue_topology = object()
552+
axes_topology = SimpleNamespace(residue={(3, 0): residue_topology})
553+
axes_manager.get_residue_axes_from_topology.return_value = expected
554+
555+
result = node._get_residue_axes(
556+
u=FakeUniverse([mol]),
557+
mol=mol,
558+
mol_id=3,
559+
bead=FakeAtomGroup("res"),
560+
local_res_i=0,
561+
axes_manager=axes_manager,
562+
axes_topology=axes_topology,
563+
box=None,
564+
customised_axes=True,
565+
)
566+
567+
assert result == expected
568+
called_kwargs = axes_manager.get_residue_axes_from_topology.call_args.kwargs
569+
assert called_kwargs["topology"] is residue_topology
570+
assert called_kwargs["residue_atoms"] is mol.residues[0].atoms
571+
axes_manager.get_residue_axes.assert_not_called()
572+
573+
539574
def test_get_residue_axes_customised_delegates_to_axes_manager():
540575
node = FrameCovarianceNode()
541576
mol = FakeMolecule(n_residues=1)
@@ -545,10 +580,14 @@ def test_get_residue_axes_customised_delegates_to_axes_manager():
545580

546581
assert (
547582
node._get_residue_axes(
583+
u=FakeUniverse([mol]),
548584
mol=mol,
585+
mol_id=0,
549586
bead=FakeAtomGroup("res"),
550587
local_res_i=0,
551588
axes_manager=axes_manager,
589+
axes_topology=None,
590+
box=None,
552591
customised_axes=True,
553592
)
554593
== expected
@@ -573,10 +612,14 @@ def test_get_residue_axes_vanilla_uses_make_whole_and_vanilla_axes():
573612

574613
with patch("CodeEntropy.levels.nodes.covariance.make_whole") as make_whole:
575614
trans_axes, rot_axes, center, moi = node._get_residue_axes(
615+
u=FakeUniverse([mol]),
576616
mol=mol,
617+
mol_id=0,
577618
bead=bead,
578619
local_res_i=0,
579620
axes_manager=axes_manager,
621+
axes_topology=None,
622+
box=None,
580623
customised_axes=False,
581624
)
582625

‎tests/unit/CodeEntropy/levels/test_axes.py‎

Lines changed: 104 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import pytest
55

66
from CodeEntropy.levels.axes import AxesCalculator
7-
from CodeEntropy.levels.nodes.axes_topology import UAAxesTopology
7+
from CodeEntropy.levels.nodes.axes_topology import ResidueAxesTopology, UAAxesTopology
88

99

1010
class _FakeAtom:
@@ -751,6 +751,109 @@ def _ua_topology(
751751
)
752752

753753

754+
def _residue_topology(
755+
*,
756+
residue_heavy_indices=(1,),
757+
residue_ua_masses=(12.0,),
758+
has_neighbor_bonds=False,
759+
):
760+
"""Build a small cached residue topology fixture."""
761+
return ResidueAxesTopology(
762+
residue_heavy_indices=np.asarray(residue_heavy_indices, dtype=int),
763+
residue_ua_masses=np.asarray(residue_ua_masses, dtype=float),
764+
has_neighbor_bonds=bool(has_neighbor_bonds),
765+
)
766+
767+
768+
def test_get_residue_axes_from_topology_no_neighbor_bonds_uses_cached_indices(
769+
monkeypatch,
770+
):
771+
ax = AxesCalculator()
772+
773+
heavy_atom = _FakeAtom(1, 12.0, [1.0, 2.0, 3.0])
774+
other_heavy = _FakeAtom(3, 14.0, [4.0, 5.0, 6.0])
775+
universe = _FakeUniverse({1: heavy_atom, 3: other_heavy})
776+
mol = MagicMock()
777+
residue_atoms = MagicMock()
778+
residue_atoms.center_of_mass.return_value = np.array([9.0, 8.0, 7.0])
779+
topology = _residue_topology(
780+
residue_heavy_indices=(1, 3),
781+
residue_ua_masses=(13.0, 14.0),
782+
has_neighbor_bonds=False,
783+
)
784+
785+
get_tensor = MagicMock(return_value=np.eye(3))
786+
get_principal = MagicMock(return_value=(np.eye(3) * 2.0, np.array([3.0, 2.0, 1.0])))
787+
788+
monkeypatch.setattr(ax, "get_moment_of_inertia_tensor", get_tensor)
789+
monkeypatch.setattr(ax, "get_custom_principal_axes", get_principal)
790+
791+
box = np.array([20.0, 30.0, 40.0])
792+
trans_axes, rot_axes, center, moi = ax.get_residue_axes_from_topology(
793+
u=universe,
794+
mol=mol,
795+
residue_atoms=residue_atoms,
796+
topology=topology,
797+
box=box,
798+
)
799+
800+
np.testing.assert_allclose(trans_axes, np.eye(3) * 2.0)
801+
np.testing.assert_allclose(rot_axes, np.eye(3) * 2.0)
802+
np.testing.assert_allclose(center, np.array([9.0, 8.0, 7.0]))
803+
np.testing.assert_allclose(moi, np.array([3.0, 2.0, 1.0]))
804+
805+
tensor_kwargs = get_tensor.call_args.kwargs
806+
np.testing.assert_allclose(
807+
tensor_kwargs["center_of_mass"],
808+
np.array([9.0, 8.0, 7.0]),
809+
)
810+
np.testing.assert_allclose(
811+
tensor_kwargs["positions"],
812+
np.array([[1.0, 2.0, 3.0], [4.0, 5.0, 6.0]]),
813+
)
814+
np.testing.assert_allclose(tensor_kwargs["masses"], np.array([13.0, 14.0]))
815+
np.testing.assert_allclose(tensor_kwargs["dimensions"], box)
816+
get_principal.assert_called_once()
817+
818+
819+
def test_get_residue_axes_from_topology_neighbor_bonds_uses_vanilla_axes(
820+
monkeypatch,
821+
):
822+
ax = AxesCalculator()
823+
824+
universe = _FakeUniverse(
825+
{},
826+
dimensions=[11.0, 12.0, 13.0, 90.0, 90.0, 90.0],
827+
)
828+
mol = MagicMock()
829+
mol.atoms.principal_axes.return_value = np.eye(3) * 5.0
830+
residue_atoms = MagicMock()
831+
residue_atoms.center_of_mass.return_value = np.array([1.0, 2.0, 3.0])
832+
topology = _residue_topology(has_neighbor_bonds=True)
833+
834+
make_whole = MagicMock()
835+
get_vanilla = MagicMock(return_value=(np.eye(3) * 6.0, np.array([6.0, 5.0, 4.0])))
836+
837+
monkeypatch.setattr("CodeEntropy.levels.axes.make_whole", make_whole)
838+
monkeypatch.setattr(ax, "get_vanilla_axes", get_vanilla)
839+
840+
trans_axes, rot_axes, center, moi = ax.get_residue_axes_from_topology(
841+
u=universe,
842+
mol=mol,
843+
residue_atoms=residue_atoms,
844+
topology=topology,
845+
box=None,
846+
)
847+
848+
make_whole.assert_called_once_with(mol.atoms)
849+
mol.atoms.principal_axes.assert_called_once()
850+
get_vanilla.assert_called_once_with(residue_atoms)
851+
np.testing.assert_allclose(trans_axes, np.eye(3) * 5.0)
852+
np.testing.assert_allclose(rot_axes, np.eye(3) * 6.0)
853+
np.testing.assert_allclose(center, np.array([1.0, 2.0, 3.0]))
854+
np.testing.assert_allclose(moi, np.array([6.0, 5.0, 4.0]))
855+
856+
754857
def test_get_UA_axes_from_topology_multiple_heavy_uses_cached_indices_and_box(
755858
monkeypatch,
756859
):

0 commit comments

Comments
 (0)