tests(serializer): ensure internal fields are removed

Author: palkerecsenyi

cds/modules/records/serializers/json.py

@@ -95,7 +95,6 @@ def _remove_internal_fields(self, record, metadata):
             metadata.pop("_access", None)
             metadata.pop("_buckets", None)
             metadata.pop("_cds", None)
-            metadata.pop("_deposit", None)
         return metadata
 
     def preprocess_record(self, pid, record, links_factory=None):

tests/unit/test_serializer.py

@@ -173,6 +173,16 @@ def test_cds_json_serializer_sanitization(video_record_metadata):
             'title': {'title': '<script>alert("bad")</script> Titre'}
         }
     ]
+
+    record["_access"] = {
+        "key": "value"
+    }
+    record["_buckets"] = {
+        "key":"value"
+    }
+    record["_cds"] = {
+        "key":"value"
+    }
 
     # Test the serializer
     serializer = CDSJSONSerializer()
@@ -201,3 +211,7 @@ def test_cds_json_serializer_sanitization(video_record_metadata):
     translations = result['metadata']['translations']
     for tr in translations:
         assert '<script>' not in tr['description']
+
+    assert "_access" not in result
+    assert "_buckets" not in result
+    assert "_cds" not in result