fix: deposit form bug - #2097
Merged
zzacharo merged 2 commits intoAug 27, 2025
Merged
Conversation
zzacharo
reviewed
Aug 27, 2025
| that.stateReporter[state].status = value; | ||
| } | ||
| }); | ||
| that.calculateCurrentDepositStatus(); |
Contributor
There was a problem hiding this comment.
this method will take into account also the chapters task status....Can you check if the chapters task is failed what happens in the UI?
Contributor
Author
There was a problem hiding this comment.
This will remove the chapters task from overall state: d5d85bb
zubeydecivelek
force-pushed
the
chapters
branch
from
August 27, 2025 12:21
d5d85bb to
d399400
Compare
zzacharo
approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
file_video_extract_chapter_framesis not a main task, it's not indepositStatesandthat.stateReporter. And it was failing during the status update