chapters: improve ExtractChapterFramesTask - #2099
Merged
zzacharo merged 1 commit intoAug 28, 2025
Merged
Conversation
zzacharo
approved these changes
Aug 28, 2025
zubeydecivelek
force-pushed
the
chapters
branch
2 times, most recently
from
August 28, 2025 12:31
f09ed8d to
506e7c0
Compare
zzacharo
reviewed
Aug 28, 2025
| for slave in slaves: | ||
| ts_val = next(t.value for t in slave.tags if t.key == "timestamp") | ||
| if ts_val in valid_chapter_seconds: | ||
| continue |
Contributor
There was a problem hiding this comment.
we need to eventually dispose also the chapters.vtt if we don't keep any chapter...
zubeydecivelek
force-pushed
the
chapters
branch
from
August 28, 2025 13:55
506e7c0 to
2a8670b
Compare
zzacharo
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup
Chapters VTT for player
Landing page