Skip to content

Fix download stats #2158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zzacharo merged 3 commits into from
Jan 28, 2026
Merged

Fix download stats #2158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac64468
requirements: bump counter-robots lib
zzacharo Dec 9, 2025
61e7519
fix(stats): remove double variable assignment
zzacharo Jan 28, 2026
f752764
fix(keywords): escape double quotes on keyword name
zzacharo Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cds/modules/records/static/templates/cds_records/keywords.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ <h3 class="cds-title-section-decoration bt bw-1 pt-10 mb-20"><i class="fa fa-tag
<div class="cds-tags cds-keywords">
<ul>
<li ng-repeat="keyword in record.metadata.keywords">
<a ng-href='/search?q=keywords.name:"{{ keyword.name }}"'>{{ keyword.name }}</a>
<a ng-href='/search?q=keywords.name:"{{ keyword.name.replace(/"/g, '\\"') }}"'>{{ keyword.name }}</a>
</li>
</ul>
</div>
Expand Down
2 changes: 0 additions & 2 deletions cds/modules/stats/event_builders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

def file_download_event_builder(event, sender_app, obj=None, record=None, **kwargs):
"""Build a file-download event."""
tags = obj.get_tags()
# File information
content_type = splitext(obj.key)[1][1:].lower()
tags = obj.get_tags()
Expand Down Expand Up @@ -56,7 +55,6 @@ def media_record_view_event_builder(event, sender_app, obj=None, record=None, **

This is the event tracking users clicking the play button on videos.
"""
tags = obj.get_tags()
# File information
content_type = splitext(obj.key)[1][1:].lower()
tags = obj.get_tags()
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ click-didyoumean==0.3.1
click-plugins==1.1.1
click-repl==0.3.0
commonmark==0.9.1
counter-robots==2018.6
counter-robots==2025.11
cryptography==44.0.0
datacite==1.2.0
dcxml==0.1.1
Expand Down