Fire hooks when timed punishments are applied or removed - #193
Merged
Conversation
Fires CFC_TimedPunishments_Punished and CFC_TimedPunishments_Unpunished so external addons (e.g. gm_audit_glua) can react to punishment changes without patching this module. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adds addon-facing hooks around timed punishment state changes so external modules can react without patching timed punishments internals (per PR description, for gm_audit_glua integration).
Changes:
- Fire
CFC_TimedPunishments_Punishedafter persisting a new timed punishment. - Fire
CFC_TimedPunishments_Unpunishedafter removing a timed punishment from persistence.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
31
to
35
| function TP.Punish( steamID64, punishment, expiration, issuer, reason ) | ||
| Data:createPunishment( punishment, steamID64, expiration, issuer, reason ) | ||
| hook.Run( "CFC_TimedPunishments_Punished", steamID64, punishment, expiration, issuer, reason ) | ||
|
|
||
| local ply = player.GetBySteamID64( steamID64 ) |
Comment on lines
47
to
51
| function TP.Unpunish( steamID64, punishment ) | ||
| Data:removePunishment( punishment, steamID64 ) | ||
| hook.Run( "CFC_TimedPunishments_Unpunished", steamID64, punishment ) | ||
|
|
||
| local ply = player.GetBySteamID64( steamID64 ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CFC_TimedPunishments_Punished(steamID64, punishment, expiration, issuer, reason) inTP.Punishafter writing to the local DBCFC_TimedPunishments_Unpunished(steamID64, punishment) inTP.Unpunishafter removing from the local DBThis allows external addons to react to timed punishment changes without patching this module. Specifically intended for gm_audit_glua integration.
Test plan
CFC_TimedPunishments_Punishedfires with correct argsCFC_TimedPunishments_Unpunishedfires