Skip to content

Commit 834a243

Browse files
authored
ggml-webgpu: Enable NVIDIA self-hosted CI (ggml-org#22976)
* Enabel nvidia ci for webgpu * Address precision issues * fix placement * Relax more set_rows and div * Try relaxing all f16 * formatting and naming * Add comment explaining max_nmse_err logic Added comment referencing pull request for clarification.
1 parent 5ec717d commit 834a243

2 files changed

Lines changed: 54 additions & 28 deletions

File tree

‎.github/workflows/build-self-hosted.yml‎

Lines changed: 25 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -120,35 +120,34 @@ jobs:
120120
vulkaninfo --summary
121121
GG_BUILD_VULKAN=1 bash ./ci/run.sh ~/results/llama.cpp /mnt/llama.cpp
122122
123-
# TODO: investigate slight precision issues in some operations for test-backend-ops on the WebGPU backend.
124-
#ggml-ci-nvidia-webgpu:
125-
# runs-on: [self-hosted, Linux, NVIDIA]
123+
ggml-ci-nvidia-webgpu:
124+
runs-on: [self-hosted, Linux, NVIDIA]
126125

127-
# steps:
128-
# - name: Clone
129-
# id: checkout
130-
# uses: actions/checkout@v6
126+
steps:
127+
- name: Clone
128+
id: checkout
129+
uses: actions/checkout@v6
131130

132-
# - name: Dawn Dependency
133-
# id: dawn-depends
134-
# run: |
135-
# DAWN_VERSION="v20260317.182325"
136-
# DAWN_OWNER="google"
137-
# DAWN_REPO="dawn"
138-
# DAWN_ASSET_NAME="Dawn-18eb229ef5f707c1464cc581252e7603c73a3ef0-ubuntu-latest-Release"
139-
# echo "Fetching release asset from https://github.com/google/dawn/releases/download/${DAWN_VERSION}/${DAWN_ASSET_NAME}.tar.gz"
140-
# curl -L -o artifact.tar.gz \
141-
# "https://github.com/google/dawn/releases/download/${DAWN_VERSION}/${DAWN_ASSET_NAME}.tar.gz"
142-
# mkdir dawn
143-
# tar -xvf artifact.tar.gz -C dawn --strip-components=1
131+
- name: Dawn Dependency
132+
id: dawn-depends
133+
run: |
134+
DAWN_VERSION="v20260317.182325"
135+
DAWN_OWNER="google"
136+
DAWN_REPO="dawn"
137+
DAWN_ASSET_NAME="Dawn-18eb229ef5f707c1464cc581252e7603c73a3ef0-ubuntu-latest-Release"
138+
echo "Fetching release asset from https://github.com/google/dawn/releases/download/${DAWN_VERSION}/${DAWN_ASSET_NAME}.tar.gz"
139+
curl -L -o artifact.tar.gz \
140+
"https://github.com/google/dawn/releases/download/${DAWN_VERSION}/${DAWN_ASSET_NAME}.tar.gz"
141+
mkdir dawn
142+
tar -xvf artifact.tar.gz -C dawn --strip-components=1
144143
145-
# - name: Test
146-
# id: ggml-ci
147-
# run: |
148-
# GG_BUILD_WEBGPU=1 \
149-
# GG_BUILD_WEBGPU_DAWN_PREFIX="$GITHUB_WORKSPACE/dawn" \
150-
# GG_BUILD_WEBGPU_DAWN_DIR="$GITHUB_WORKSPACE/dawn/lib64/cmake/Dawn" \
151-
# bash ./ci/run.sh ~/results/llama.cpp /mnt/llama.cpp
144+
- name: Test
145+
id: ggml-ci
146+
run: |
147+
GG_BUILD_WEBGPU=1 \
148+
GG_BUILD_WEBGPU_DAWN_PREFIX="$GITHUB_WORKSPACE/dawn" \
149+
GG_BUILD_WEBGPU_DAWN_DIR="$GITHUB_WORKSPACE/dawn/lib64/cmake/Dawn" \
150+
bash ./ci/run.sh ~/results/llama.cpp /mnt/llama.cpp
152151
153152
# TODO: provision AMX-compatible machine
154153
#ggml-ci-cpu-amx:

‎tests/test-backend-ops.cpp‎

Lines changed: 29 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1128,7 +1128,11 @@ struct test_case {
11281128
}
11291129

11301130
virtual double max_nmse_err(ggml_backend_t backend) {
1131-
GGML_UNUSED(backend);
1131+
ggml_backend_reg_t reg = ggml_backend_dev_backend_reg(ggml_backend_get_device(backend));
1132+
// See https://github.com/ggml-org/llama.cpp/pull/22976 for explanation.
1133+
if (contains_f16 && strcmp(ggml_backend_reg_name(reg), "WebGPU") == 0) {
1134+
return std::max(max_nmse_err(), 1e-6);
1135+
}
11321136
return max_nmse_err();
11331137
}
11341138

@@ -1205,6 +1209,18 @@ struct test_case {
12051209
std::vector<ggml_tensor *> sentinels;
12061210

12071211
std::string current_op_name;
1212+
bool contains_f16 = false;
1213+
1214+
// Used by the WebGPU backend to relax error thresholds on ops on f16 tensors
1215+
void check_for_f16_tensor(ggml_context * ctx) {
1216+
contains_f16 = false;
1217+
for (ggml_tensor * t = ggml_get_first_tensor(ctx); t != nullptr; t = ggml_get_next_tensor(ctx, t)) {
1218+
if (t->type == GGML_TYPE_F16) {
1219+
contains_f16 = true;
1220+
break;
1221+
}
1222+
}
1223+
}
12081224

12091225
void add_sentinel(ggml_context * ctx) {
12101226
if (mode == MODE_PERF || mode == MODE_GRAD || mode == MODE_SUPPORT) {
@@ -1298,6 +1314,7 @@ struct test_case {
12981314

12991315
ggml_tensor * out = build_graph(ctx);
13001316
current_op_name = op_desc(out);
1317+
check_for_f16_tensor(ctx);
13011318

13021319
if (!matches_filter(out, op_names_filter)) {
13031320
//printf(" %s: skipping\n", op_desc(out).c_str());
@@ -1973,9 +1990,19 @@ struct test_unary : public test_case {
19731990
}
19741991

19751992
void initialize_tensors(ggml_context * ctx) override {
1993+
float min = -150.f;
1994+
float max = 150.f;
1995+
1996+
// Keep FP16 exp/expm1 inputs in-range so all backends stay finite instead of
1997+
// disagreeing on whether overflow saturates to max-F16 or produces +inf.
1998+
if (type == GGML_TYPE_F16 && (op == GGML_UNARY_OP_EXP || op == GGML_UNARY_OP_EXPM1)) {
1999+
min = -10.f;
2000+
max = 10.f;
2001+
}
2002+
19762003
for (ggml_tensor * t = ggml_get_first_tensor(ctx); t != NULL; t = ggml_get_next_tensor(ctx, t)) {
19772004
// test extended range of values to check for NaNs in GELU
1978-
init_tensor_uniform(t, -150.f, 150.f);
2005+
init_tensor_uniform(t, min, max);
19792006
}
19802007
}
19812008

0 commit comments

Comments
 (0)