ci: move commitlint config to .mjs — the lint gate has been asserting nothing - #60
Open
CSOAI-ORG wants to merge 1 commit into
Open
ci: move commitlint config to .mjs — the lint gate has been asserting nothing#60CSOAI-ORG wants to merge 1 commit into
CSOAI-ORG wants to merge 1 commit into
Conversation
wagoid/commitlint-github-action v6.2.1 refuses a .js configFile: error running commitlint .js extension is not allowed for the configFile, please use .mjs instead ##[error]You have commit messages with errors So the Conventional commits job has been failing on every pull request regardless of what the commit messages actually say. It reports a commit message error that is really a config-loader error, which means the gate has been asserting nothing while looking red. Renames .github/commitlint.config.js to .mjs, converts module.exports to an ESM default export, and points the workflow at the new path. The rule set is unchanged: @commitlint/config-conventional. Signed-off-by: CSOAI-ORG <nicholas@csoai.org> Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The failure
The
Conventional commits/lintjob fails on every pull request. Latest example: run 33709989136.Why this matters more than a red tick
The error message says "You have commit messages with errors" — but commitlint never linted anything.
wagoid/commitlint-github-action@v6(6.2.1) refuses to load a.jsconfig file, bails out, and the action reports it as a commit-message failure.So the gate has been red for a reason unrelated to commit messages, and green for nobody — it has not actually validated a single commit message since the action started rejecting
.js. A permanently-red check that asserts nothing is worse than no check: it trains everyone to ignore it.The change
.github/commitlint.config.js->.github/commitlint.config.mjsmodule.exports = {...}->export default {...}configFile:updated to the new pathThe rule set is unchanged — still
@commitlint/config-conventional. This is not a relaxation; it makes an existing gate actually execute. Expect it to start failing PRs with genuinely non-conventional commit messages, which is the point.Separate, not fixed here
dependency-reviewalso fails on every PR:That is a repository setting, not code — Dependency graph is off. It cannot be fixed by a PR. (Org-wide: Dependabot alerts are disabled on 285 of 297 non-archived repos, so this is not an isolated case.)
🤖 Generated with Claude Code